Completed
Push — master ( 4d09f2...0e6999 )
by Robin
66:06 queued 64:59
created
src/Wrapped/Share.php 2 patches
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,6 +113,10 @@  discard block
 block discarded – undo
113 113
 		return $this->name;
114 114
 	}
115 115
 
116
+	/**
117
+	 * @param string $command
118
+	 * @param string $path
119
+	 */
116 120
 	protected function simpleCommand($command, $path) {
117 121
 		$escapedPath = $this->escapePath($path);
118 122
 		$cmd = $command . ' ' . $escapedPath;
@@ -323,7 +327,7 @@  discard block
 block discarded – undo
323 327
 	/**
324 328
 	 * @param string $path
325 329
 	 * @param int $mode a combination of FileInfo::MODE_READONLY, FileInfo::MODE_ARCHIVE, FileInfo::MODE_SYSTEM and FileInfo::MODE_HIDDEN, FileInfo::NORMAL
326
-	 * @return mixed
330
+	 * @return boolean
327 331
 	 */
328 332
 	public function setMode($path, $mode) {
329 333
 		$modeString = '';
@@ -373,7 +377,7 @@  discard block
 block discarded – undo
373 377
 
374 378
 	/**
375 379
 	 * @param string $command
376
-	 * @return array
380
+	 * @return string[]
377 381
 	 */
378 382
 	protected function execute($command) {
379 383
 		$this->connect();
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -13,14 +13,11 @@
 block discarded – undo
13 13
 use Icewind\SMB\Exception\FileInUseException;
14 14
 use Icewind\SMB\Exception\InvalidTypeException;
15 15
 use Icewind\SMB\Exception\NotFoundException;
16
-use Icewind\SMB\Exception\InvalidRequestException;
17 16
 use Icewind\SMB\IFileInfo;
18 17
 use Icewind\SMB\INotifyHandler;
19 18
 use Icewind\SMB\IServer;
20 19
 use Icewind\SMB\ISystem;
21 20
 use Icewind\Streams\CallbackWrapper;
22
-use Icewind\SMB\Native\NativeShare;
23
-use Icewind\SMB\Native\NativeServer;
24 21
 
25 22
 class Share extends AbstractShare {
26 23
 	/**
Please login to merge, or discard this patch.
src/Wrapped/Server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 	 * Check if the smbclient php extension is available
21 21
 	 *
22 22
 	 * @param ISystem $system
23
-	 * @return bool
23
+	 * @return string|boolean
24 24
 	 */
25 25
 	public static function available(ISystem $system) {
26 26
 		return $system->getSmbclientPath();
Please login to merge, or discard this patch.
src/Wrapped/Connection.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -21,6 +21,9 @@
 block discarded – undo
21 21
 	/** @var Parser */
22 22
 	private $parser;
23 23
 
24
+	/**
25
+	 * @param string $command
26
+	 */
24 27
 	public function __construct($command, Parser $parser, $env = []) {
25 28
 		parent::__construct($command, $env);
26 29
 		$this->parser = $parser;
Please login to merge, or discard this patch.