Completed
Pull Request — master (#70)
by Raffael
10:29
created
src/Native/NativeReadStream.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 	/**
32 32
 	 * Wrap a stream from libsmbclient-php into a regular php stream
33 33
 	 *
34
-	 * @param \Icewind\SMB\NativeState $state
34
+	 * @param NativeState $state
35 35
 	 * @param resource $smbStream
36 36
 	 * @param string $mode
37 37
 	 * @param string $url
Please login to merge, or discard this patch.
src/Wrapped/Connection.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 	/** @var Parser */
21 21
 	private $parser;
22 22
 
23
+	/**
24
+	 * @param string $command
25
+	 */
23 26
 	public function __construct($command, Parser $parser, $env = array()) {
24 27
 		parent::__construct($command, $env);
25 28
 		$this->parser = $parser;
@@ -75,7 +78,7 @@  discard block
 block discarded – undo
75 78
 	/**
76 79
 	 * Check
77 80
 	 *
78
-	 * @param $line
81
+	 * @param string|false $line
79 82
 	 * @return bool
80 83
 	 */
81 84
 	private function isPrompt($line) {
Please login to merge, or discard this patch.
src/Native/NativeWriteStream.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 	/**
32 32
 	 * Wrap a stream from libsmbclient-php into a regular php stream
33 33
 	 *
34
-	 * @param \Icewind\SMB\NativeState $state
34
+	 * @param NativeState $state
35 35
 	 * @param resource $smbStream
36 36
 	 * @param string $mode
37 37
 	 * @param string $url
Please login to merge, or discard this patch.
src/Wrapped/Server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 	 * Check if the smbclient php extension is available
21 21
 	 *
22 22
 	 * @param ISystem $system
23
-	 * @return bool
23
+	 * @return string|boolean
24 24
 	 */
25 25
 	public static function available(ISystem $system) {
26 26
 		return $system->getSmbclientPath();
Please login to merge, or discard this patch.
src/Wrapped/Share.php 1 patch
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -121,6 +121,10 @@  discard block
 block discarded – undo
121 121
 		return $this->name;
122 122
 	}
123 123
 
124
+	/**
125
+	 * @param string $command
126
+	 * @param string $path
127
+	 */
124 128
 	protected function simpleCommand($command, $path) {
125 129
 		$escapedPath = $this->escapePath($path);
126 130
 		$cmd = $command . ' ' . $escapedPath;
@@ -131,7 +135,7 @@  discard block
 block discarded – undo
131 135
 	/**
132 136
 	 * List the content of a remote folder
133 137
 	 *
134
-	 * @param $path
138
+	 * @param string $path
135 139
 	 * @return \Icewind\SMB\IFileInfo[]
136 140
 	 *
137 141
 	 * @throws \Icewind\SMB\Exception\NotFoundException
@@ -344,7 +348,7 @@  discard block
 block discarded – undo
344 348
 	/**
345 349
 	 * @param string $path
346 350
 	 * @param int $mode a combination of FileInfo::MODE_READONLY, FileInfo::MODE_ARCHIVE, FileInfo::MODE_SYSTEM and FileInfo::MODE_HIDDEN, FileInfo::NORMAL
347
-	 * @return mixed
351
+	 * @return boolean
348 352
 	 */
349 353
 	public function setMode($path, $mode) {
350 354
 		$modeString = '';
@@ -388,7 +392,7 @@  discard block
 block discarded – undo
388 392
 
389 393
 	/**
390 394
 	 * @param string $command
391
-	 * @return array
395
+	 * @return string[]
392 396
 	 */
393 397
 	protected function execute($command) {
394 398
 		$this->connect();
Please login to merge, or discard this patch.
src/Native/NativeShare.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
 		return $this->name;
67 67
 	}
68 68
 
69
+	/**
70
+	 * @param string $path
71
+	 */
69 72
 	private function buildUrl($path) {
70 73
 		$this->verifyPath($path);
71 74
 		$url = sprintf('smb://%s/%s', $this->server->getHost(), $this->name);
@@ -295,7 +298,7 @@  discard block
 block discarded – undo
295 298
 	 *
296 299
 	 * @param string $path
297 300
 	 * @param string $attribute attribute to get the info
298
-	 * @param mixed $value
301
+	 * @param integer $value
299 302
 	 * @return string the attribute value
300 303
 	 */
301 304
 	public function setAttribute($path, $attribute, $value) {
@@ -312,7 +315,7 @@  discard block
 block discarded – undo
312 315
 	 *
313 316
 	 * @param string $path
314 317
 	 * @param int $mode a combination of FileInfo::MODE_READONLY, FileInfo::MODE_ARCHIVE, FileInfo::MODE_SYSTEM and FileInfo::MODE_HIDDEN, FileInfo::NORMAL
315
-	 * @return mixed
318
+	 * @return string
316 319
 	 */
317 320
 	public function setMode($path, $mode) {
318 321
 		return $this->setAttribute($path, 'system.dos_attr.mode', $mode);
Please login to merge, or discard this patch.