IPub\Permissions\TPermission

Complexity

Total Complexity

5

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

92.86%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	injectPermission()	0	7	1
B	checkRequirements()	0	22	4

<?php
/**
 * TPermission.php
 *
 * @copyright      More in license.md
 * @license        https://www.ipublikuj.eu
 * @author         Adam Kadlec https://www.ipublikuj.eu
 * @package        iPublikuj:Permissions!
 * @subpackage     common
 * @since          1.0.0
 *
 * @date           13.10.14
 */

declare(strict_types = 1);

namespace IPub\Permissions;

use Nette\Application;

use IPub\Permissions\Security;

/**
 * Helper trait
 *
 * @package        iPublikuj:Permissions!
 * @subpackage     common
 *
 * @author         Adam Kadlec <adam.kadlec@ipublikuj.eu>
 */
trait TPermission
{
	/**
	 * @var Configuration
	 */
	protected $permissionConfiguration;

	/**
	 * @var Access\ICheckRequirements
	 */
	protected $requirementsChecker;

	/**
	 * @param Access\ICheckRequirements $requirementsChecker
	 * @param Configuration $configuration
	 */
	public function injectPermission(
		Access\ICheckRequirements $requirementsChecker,
		Configuration $configuration
	) {
		$this->requirementsChecker = $requirementsChecker;
		$this->permissionConfiguration = $configuration;
	}

	/**
	 * @param mixed $element
	 *
	 * @return void
	 *
	 * @throws Application\ForbiddenRequestException
	 */
	public function checkRequirements($element) : void
	{
		$redirectUrl = $this->permissionConfiguration->getRedirectUrl([
			'backlink' => $this->storeRequest(),

It seems like storeRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		]);

		try {
			parent::checkRequirements($element);

			if (!$this->requirementsChecker->isAllowed($element)) {
				throw new Application\ForbiddenRequestException;
			}

		} catch (Application\ForbiddenRequestException $ex) {
			if ($redirectUrl) {
				$this->getPresenter()->redirectUrl($redirectUrl);

It seems like getPresenter() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			} else {
				throw $ex;
			}
		}
	}
}