TPermission::injectPermission() - Code Metrics - Inspection of "- Refactoring to PHP7.2" - iPublikuj/permissions - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6c3219...97ce76 )

by Adam

created 2018-03-18 09:18 UTC

TPermission::injectPermission() A

↳ Parent: TPermission

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	2
crap	1

<?php
/**
 * TPermission.php
 *
 * @copyright      More in license.md
 * @license        https://www.ipublikuj.eu
 * @author         Adam Kadlec https://www.ipublikuj.eu
 * @package        iPublikuj:Permissions!
 * @subpackage     common
 * @since          1.0.0
 *
 * @date           13.10.14
 */

declare(strict_types = 1);

namespace IPub\Permissions;

use Nette\Application;

use IPub\Permissions\Security;

/**
 * Helper trait
 *
 * @package        iPublikuj:Permissions!
 * @subpackage     common
 *
 * @author         Adam Kadlec <[email protected]>
 */
trait TPermission
{
	/**
	 * @var Configuration
	 */
	protected $permissionConfiguration;

	/**
	 * @var Access\ICheckRequirements
	 */
	protected $requirementsChecker;

	/**
	 * @param Access\ICheckRequirements $requirementsChecker
	 * @param Configuration $configuration
	 */
	public function injectPermission(
		Access\ICheckRequirements $requirementsChecker,
		Configuration $configuration
	) {
		$this->requirementsChecker = $requirementsChecker;
		$this->permissionConfiguration = $configuration;
	}

	/**
	 * @param mixed $element
	 *
	 * @return void
	 *
	 * @throws Application\ForbiddenRequestException
	 */
	public function checkRequirements($element) : void
	{
		$redirectUrl = $this->permissionConfiguration->getRedirectUrl([
			'backlink' => $this->storeRequest(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
		]);

		try {
			parent::checkRequirements($element);

			if (!$this->requirementsChecker->isAllowed($element)) {
				throw new Application\ForbiddenRequestException;
			}

		} catch (Application\ForbiddenRequestException $ex) {
			if ($redirectUrl) {
				$this->getPresenter()->redirectUrl($redirectUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

			} else {
				throw $ex;
			}
		}
	}
}


1		<?php
2		/**
3		* TPermission.php
4		*
5		* @copyright More in license.md
6		* @license https://www.ipublikuj.eu
7		* @author Adam Kadlec https://www.ipublikuj.eu
8		* @package iPublikuj:Permissions!
9		* @subpackage common
10		* @since 1.0.0
11		*
12		* @date 13.10.14
13		*/
14
15		declare(strict_types = 1);
16
17		namespace IPub\Permissions;
18
19		use Nette\Application;
20
21		use IPub\Permissions\Security;
22
23		/**
24		* Helper trait
25		*
26		* @package iPublikuj:Permissions!
27		* @subpackage common
28		*
29		* @author Adam Kadlec <[email protected]>
30		*/
31	1	trait TPermission
32		{
33		/**
34		* @var Configuration
35		*/
36		protected $permissionConfiguration;
37
38		/**
39		* @var Access\ICheckRequirements
40		*/
41		protected $requirementsChecker;
42
43		/**
44		* @param Access\ICheckRequirements $requirementsChecker
45		* @param Configuration $configuration
46		*/
47		public function injectPermission(
48		Access\ICheckRequirements $requirementsChecker,
49		Configuration $configuration
50		) {
51	1	$this->requirementsChecker = $requirementsChecker;
52	1	$this->permissionConfiguration = $configuration;
53	1	}
54
55		/**
56		* @param mixed $element
57		*
58		* @return void
59		*
60		* @throws Application\ForbiddenRequestException
61		*/
62		public function checkRequirements($element) : void
63		{
64	1	$redirectUrl = $this->permissionConfiguration->getRedirectUrl([
65	1	'backlink' => $this->storeRequest(),
		0 ignored issues – show Bug introduced 2016-11-30 22:57 UTC by Report Bug Copy Issue Report It seems like `storeRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
66		]);
67
68		try {
69	1	parent::checkRequirements($element);
70
71	1	if (!$this->requirementsChecker->isAllowed($element)) {
72	1	throw new Application\ForbiddenRequestException;
73		}
74
75	1	} catch (Application\ForbiddenRequestException $ex) {
76	1	if ($redirectUrl) {
77		$this->getPresenter()->redirectUrl($redirectUrl);
		0 ignored issues – show Bug introduced 2016-11-30 22:57 UTC by Report Bug Copy Issue Report It seems like `getPresenter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
78
79		} else {
80	1	throw $ex;
81		}
82		}
83	1	}
84		}
85

iPublikuj / permissions

Push — master ( 6c3219...97ce76 )

TPermission::injectPermission() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like