iJackUA / einfach-operation

src/Railway.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -6,10 +6,10 @@
 use function einfach\operation\response\isValidResponse;
 use const einfach\operation\response\RESPONSE_TYPE_ERROR;
 use const einfach\operation\response\RESPONSE_TYPE_OK;
-use einfach\operation\step\Step;
-use einfach\operation\step\Failure;
 use einfach\operation\step\AbstractStep;
 use einfach\operation\step\Always;
+use einfach\operation\step\Failure;
+use einfach\operation\step\Step;
 use einfach\operation\step\TryCatch;
 
 class Railway

Doc Comments +4 added lines

@@ -33,6 +33,9 @@ 
         $this->stepsQueue = [];
     }
 
+    /**
+     * @param string $stepName
+     */
     protected function findTargetStepIndex($stepName)
     {
         $steps = array_column($this->stepsQueue, 'step');
@@ -161,6 +164,7 @@ 
 
     /**
      * @throws \Exception
+     * @param AbstractStep $step
      */
     protected function performStep($step, &$params, $opt, $track)
     {

Indentation +2 added lines, -2 removed lines

@@ -153,12 +153,12 @@
             $opt = $item['opt'];
             /**
              * @var $step AbstractStep
-            */
+             */
             $track = $this->performStep($step, $params, $opt, $track);
 
             $failFast = $opt['failFast'] ?? null;
             if($failFast && $track == self::TRACK_FAILURE) {
-                 break;
+                    break;
             }
         }
         return new Result($params, $track, $this->signaturesPipeline);

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
     protected function findTargetStepIndex($stepName)
     {
         $steps = array_column($this->stepsQueue, 'step');
-        $names = array_map(function ($step) {
+        $names = array_map(function($step) {
             return $step->name();
         }, $steps);
 
@@ -158,7 +158,7 @@ 
             $track = $this->performStep($step, $params, $opt, $track);
 
             $failFast = $opt['failFast'] ?? null;
-            if($failFast && $track == self::TRACK_FAILURE) {
+            if ($failFast && $track == self::TRACK_FAILURE) {
                  break;
             }
         }

src/step/AbstractStep.php

Indentation +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
         $stepResult = $result;
         
         if (is_a($result, Result::class)) {
-             $stepResult = [
+                $stepResult = [
                     'params' => $result->params(),
                     'type' => ($result->isSuccess()) ? RESPONSE_TYPE_OK : RESPONSE_TYPE_ERROR
                 ];

examples/crud/CRUDController.php

Spacing +2 added lines, -2 removed lines

@@ -37,14 +37,14 @@
 
     function actionAdminDelete($params)
     {
-        $params['user'] = (object) [ 'id' => 30, 'login' => 'admin'];
+        $params['user'] = (object) ['id' => 30, 'login' => 'admin'];
         $result = (new AdminDeleteOperation)($params);
         return $this->renderOperationResult($result);
     }
 
     protected function user() 
     {
-        return (object) [ 'id' => 20, 'login' => 'yevhen'];
+        return (object) ['id' => 20, 'login' => 'yevhen'];
     }
 
     protected function renderOperationResult($result)

examples/crud/CRUDTraits.php

Spacing +2 added lines, -2 removed lines

@@ -8,7 +8,7 @@ 
     public function validate($params)
     {
         // pretend a lot of validations here
-        if($params['price'] > 100) {
+        if ($params['price'] > 100) {
             return ok($params);
         } else {
             return error($params, 'Too cheap to be true!');
@@ -17,7 +17,7 @@ 
 
     public function checkPermissions($params)
     {
-        return ( $params['user']->login == 'yevhen' ) 
+        return ($params['user']->login == 'yevhen') 
                 ? ok($params) 
                 : error($params, 'Permission denied!');
     }

examples/crud/AdminDeleteOperation.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
 
     public function checkPermissions($params) 
     {
-        return ( $params['user']->login == 'admin' ) 
+        return ($params['user']->login == 'admin') 
                 ? ok($params) 
                 : error($params, 'Permission denied!');
     }

examples/crud/example.php

Spacing +5 added lines, -5 removed lines

@@ -8,25 +8,25 @@
 
 echo "Create \n\r";
 echo $controller->actionCreate(
-        [ 'name' => 'MacBook Pro 15', 'price' => '199' ]
+        ['name' => 'MacBook Pro 15', 'price' => '199']
     );
 
 echo "Read \n\r";
 echo $controller->actionRead(
-        [ 'id' => 10 ]
+        ['id' => 10]
     );
 
 echo "Update \n\r";
 echo $controller->actionUpdate(
-        [ 'id' => 10, 'name' => 'MacBook Air', 'price' => '119' ]
+        ['id' => 10, 'name' => 'MacBook Air', 'price' => '119']
     );
 
 echo "Delete \n\r";
 echo $controller->actionDelete(
-    [ 'id' => 10 ]
+    ['id' => 10]
 );
 
 echo "Admin Delete \n\r";
 echo $controller->actionAdminDelete(
-    [ 'id' => 10 ]
+    ['id' => 10]
 );

examples/crud/CreateOperation.php

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@
     public function create($params)
     {
         // pretend it is saved to DB and ID assigned
-        $model = [ 'id' => 10, 'price' => $params['price'], 'name' => $params['name']];
-        return ok($params, [ 'model' => $model ]);
+        $model = ['id' => 10, 'price' => $params['price'], 'name' => $params['name']];
+        return ok($params, ['model' => $model]);
     }
 }

examples/crud/ReadOperation.php

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@
     public function getArticle($params)
     {
         // pretend it is taken from DB
-        $article = (object) [ 'id' => 10, 'price' => 149, 'name' => 'MacBook Pro 13' ];
-        return ok($params, [ 'model' => $article ]);
+        $article = (object) ['id' => 10, 'price' => 149, 'name' => 'MacBook Pro 13'];
+        return ok($params, ['model' => $article]);
     }
 }

examples/UpdateOperation.php

Spacing +4 added lines, -4 removed lines

@@ -10,7 +10,7 @@ 
     public function railway() : Railway
     {
         return (new Railway)
-            ->step(function ($params) {
+            ->step(function($params) {
                 echo "Hey {$params['name']}. Say hello to anonymous function!";
                 //return error($params, 'Early fail');
                 return ok($params, ['newParam' => 'newValue']);
@@ -18,7 +18,7 @@ 
             ->step([$this, 'nestedRailway'])
             ->step([$this, 'castRequest'], ['name' => 'CastReq'])
             ->step([$this, 'validateRequest'])
-            ->step(function ($params) {
+            ->step(function($params) {
                 return ok($params);
                 //return error($params, 'AAA!!!');
             }, ['failFast' => true])
@@ -28,7 +28,7 @@ 
             ->tryCatch([$this, 'sendNotification'])
             ->always([$this, 'writeLog'])
             ->failure([$this, 'notifyAdmin'], ['name' => 'Last'])
-            ->step(function ($params) {
+            ->step(function($params) {
                 return ok($params, ['a' => 'b']);
             }, ['after' => 'First', 'name' => 'FinalCheck']);
     }
@@ -41,7 +41,7 @@ 
     public function nestedRailway($params)
     {
         return (new Railway)
-            ->step(function ($params) {
+            ->step(function($params) {
                 //return error($params, 'Nested Railway failed!');
                 return ok($params, ['nestedRwParam' => 'nestedRwValue']);
             })