iFaxity / dbwebb-ramverk1-module

src/Weather/APIController.php

<?php

namespace Faxity\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

/**
 * Controller for the /ip-api routes
 */
class APIController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;


    /**
     * Handles / for the controller
     *
     * @return array
     */
    public function indexActionPost() : array
    {
        $location = $this->di->request->getPost("location", "");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $pastMonth = $this->di->request->getPost("past-month") !== null;
        $status = 200;

        try {
            $res = $this->di->weather->forecast($location, $pastMonth);

Accessing weather on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        } catch (\Exception $ex) {
            $status = 400;
            $message = $ex->getMessage();
            $res = [ "status" => $status, "message" => $message ];
        }

        return [ (array) $res, $status ];
    }
}