Faxity\Weather\APIController::indexActionPost()

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function indexActionPost() : array
    {
        $location = $this->di->request->getPost("location", "");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $pastMonth = $this->di->request->getPost("past-month") !== null;
        $status = 200;

        try {
            $res = $this->di->weather->forecast($location, $pastMonth);

Accessing weather on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        } catch (\Exception $ex) {
            $status = 400;
            $message = $ex->getMessage();
            $res = [ "status" => $status, "message" => $message ];
        }

        return [ (array) $res, $status ];
    }