App\Console\Commands\Once\GenerateTask::handle()

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

<?php
    public function handle()
    {
        $id = $this->argument('id');
        app()->singleton(SolutionServer::class, function () {
            return new SolutionServer();
        });
        if (strpos($id, '-') !== false) {

It seems like $id can also be of type array and null; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

            [$start, $end] = explode('-', $id, 2);

It seems like $id can also be of type array and null; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

            $start = intval($start);
            $end = intval($end);
            for ($i = $start; $i <= $end; $i++) {
                $this->addTask($i);
            }
        } else {
            $this->addTask($id);
        }