App\Console\Commands\Once\GenerateTask

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addTask()	0	4	1
A	handle()	0	15	3

<?php

namespace App\Console\Commands\Once;

use App\Entities\Solution;
use App\Task\SolutionServer;
use Illuminate\Console\Command;

class GenerateTask extends Command
{
    protected $signature = 'task:make {id}';

    protected $description = 'Generate Task by Solution Id';

    public function handle()
    {
        $id = $this->argument('id');
        app()->singleton(SolutionServer::class, function () {
            return new SolutionServer();
        });
        if (strpos($id, '-') !== false) {

It seems like $id can also be of type array and null; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

            [$start, $end] = explode('-', $id, 2);

It seems like $id can also be of type array and null; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

            $start = intval($start);
            $end = intval($end);
            for ($i = $start; $i <= $end; $i++) {
                $this->addTask($i);
            }
        } else {
            $this->addTask($id);
        }
    }

    private function addTask($id)
    {
        $solution = Solution::query()->findOrFail($id);
        app(SolutionServer::class)->add($solution)->send();
    }
}