Passed
Push — master ( 158c7e...b2ebb4 )
by
unknown
01:32
created
src/Routing/Conditions/Url.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 	 * 
43 43
 	 * @param string $url
44 44
 	 */
45
-	public function __construct( $url ) {
46
-		$url = UrlUtility::addLeadingSlash( $url );
47
-		$url = UrlUtility::addTrailingSlash( $url );
45
+	public function __construct($url) {
46
+		$url = UrlUtility::addLeadingSlash($url);
47
+		$url = UrlUtility::addTrailingSlash($url);
48 48
 		$this->url = $url;
49 49
 	}
50 50
 
@@ -52,28 +52,28 @@  discard block
 block discarded – undo
52 52
 	 * {@inheritDoc}
53 53
 	 */
54 54
 	public function satisfied() {
55
-		$validation_regex = $this->getValidationRegex( $this->getUrl() );
55
+		$validation_regex = $this->getValidationRegex($this->getUrl());
56 56
 		$url = $this->getCurrentPath();
57
-		return (bool) preg_match( $validation_regex, $url );
57
+		return (bool) preg_match($validation_regex, $url);
58 58
 	}
59 59
 
60 60
 	/**
61 61
 	 * {@inheritDoc}
62 62
 	 */
63 63
 	public function getArguments() {
64
-		$validation_regex = $this->getValidationRegex( $this->getUrl() );
64
+		$validation_regex = $this->getValidationRegex($this->getUrl());
65 65
 		$url = $this->getCurrentPath();
66 66
 		$matches = [];
67
-		$success = preg_match( $validation_regex, $url, $matches );
67
+		$success = preg_match($validation_regex, $url, $matches);
68 68
 
69
-		if ( ! $success ) {
69
+		if ( ! $success) {
70 70
 			return []; // this should not normally happen
71 71
 		}
72 72
 
73 73
 		$arguments = [];
74
-		$parameter_names = $this->getParameterNames( $this->getUrl() );
75
-		foreach ( $parameter_names as $parameter_name ) {
76
-			$arguments[] = ! empty( $matches[ $parameter_name ] ) ? $matches[ $parameter_name ] : '';
74
+		$parameter_names = $this->getParameterNames($this->getUrl());
75
+		foreach ($parameter_names as $parameter_name) {
76
+			$arguments[] = ! empty($matches[$parameter_name]) ? $matches[$parameter_name] : '';
77 77
 		}
78 78
 		
79 79
 		return $arguments;
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 * @return string
95 95
 	 */
96 96
 	protected function getCurrentPath() {
97
-		return UrlUtility::addTrailingSlash( UrlUtility::getCurrentPath() );
97
+		return UrlUtility::addTrailingSlash(UrlUtility::getCurrentPath());
98 98
 	}
99 99
 
100 100
 	/**
@@ -103,8 +103,8 @@  discard block
 block discarded – undo
103 103
 	 * @param  Url $url
104 104
 	 * @return Url
105 105
 	 */
106
-	public function concatenate( Url $url ) {
107
-		return new static( UrlUtility::removeTrailingSlash( $this->getUrl() ) . $url->getUrl() );
106
+	public function concatenate(Url $url) {
107
+		return new static(UrlUtility::removeTrailingSlash($this->getUrl()) . $url->getUrl());
108 108
 	}
109 109
 
110 110
 	/**
@@ -113,9 +113,9 @@  discard block
 block discarded – undo
113 113
 	 * @param  string   $url
114 114
 	 * @return string[]
115 115
 	 */
116
-	protected function getParameterNames( $url ) {
116
+	protected function getParameterNames($url) {
117 117
 		$matches = [];
118
-		preg_match_all( $this->url_regex, $url, $matches );
118
+		preg_match_all($this->url_regex, $url, $matches);
119 119
 		return $matches['name'];
120 120
 	}
121 121
 
@@ -125,29 +125,29 @@  discard block
 block discarded – undo
125 125
 	 * @param  string $url
126 126
 	 * @return string
127 127
 	 */
128
-	protected function getValidationRegex( $url ) {
128
+	protected function getValidationRegex($url) {
129 129
 		$parameters = [];
130 130
 
131 131
 		// Replace all parameters with placeholders
132
-		$validation_regex = preg_replace_callback( $this->url_regex, function( $matches ) use ( &$parameters ) {
132
+		$validation_regex = preg_replace_callback($this->url_regex, function($matches) use (&$parameters) {
133 133
 			$name = $matches['name'];
134
-			$optional = ! empty( $matches['optional'] );
135
-			$regex = ! empty( $matches['regex'] ) ? $matches['regex'] : $this->parameter_regex;
134
+			$optional = ! empty($matches['optional']);
135
+			$regex = ! empty($matches['regex']) ? $matches['regex'] : $this->parameter_regex;
136 136
 			$replacement = '(?:/(?P<' . $name . '>' . $regex . '))';
137
-			if ( $optional ) {
137
+			if ($optional) {
138 138
 				$replacement .= '?';
139 139
 			}
140 140
 
141
-			$placeholder = '___placeholder_' . sha1( count( $parameters) . '_' . $replacement . '_' . uniqid() ) . '___';
142
-			$parameters[ $placeholder ] = $replacement;
141
+			$placeholder = '___placeholder_' . sha1(count($parameters) . '_' . $replacement . '_' . uniqid()) . '___';
142
+			$parameters[$placeholder] = $replacement;
143 143
 			return $placeholder;
144
-		}, $url );
144
+		}, $url);
145 145
 
146 146
 		// quote the remaining string so that it does not get evaluated as regex
147
-		$validation_regex = preg_quote( $validation_regex, '~' );
147
+		$validation_regex = preg_quote($validation_regex, '~');
148 148
 
149 149
 		// replace the placeholders with the real parameter regexes
150
-		$validation_regex = str_replace( array_keys( $parameters ), array_values( $parameters ), $validation_regex );
150
+		$validation_regex = str_replace(array_keys($parameters), array_values($parameters), $validation_regex);
151 151
 
152 152
 		// make sure that the regex matches the entire string
153 153
 		$validation_regex = '~\A' . $validation_regex . '\z~';
Please login to merge, or discard this patch.
src/Routing/Handler.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -22,8 +22,8 @@  discard block
 block discarded – undo
22 22
 	 * 
23 23
 	 * @param string|Closure $handler
24 24
 	 */
25
-	public function __construct( $handler ) {
26
-		$this->set( $handler );
25
+	public function __construct($handler) {
26
+		$this->set($handler);
27 27
 	}
28 28
 
29 29
 	/**
@@ -32,15 +32,15 @@  discard block
 block discarded – undo
32 32
 	 * @param  string|Closure $handler
33 33
 	 * @return callable|null
34 34
 	 */
35
-	protected function parse( $handler ) {
36
-		if ( $handler instanceof Closure ) {
35
+	protected function parse($handler) {
36
+		if ($handler instanceof Closure) {
37 37
 			return $handler;
38 38
 		}
39 39
 
40
-		if ( is_string( $handler ) )  {
41
-			$handlerPieces = preg_split( '/@|::/', $handler, 2 );
42
-			if ( count( $handlerPieces ) === 1 ) {
43
-				if ( is_callable( $handlerPieces[0] ) ) {
40
+		if (is_string($handler)) {
41
+			$handlerPieces = preg_split('/@|::/', $handler, 2);
42
+			if (count($handlerPieces) === 1) {
43
+				if (is_callable($handlerPieces[0])) {
44 44
 					return $handlerPieces[0];
45 45
 				} else {
46 46
 					return null;
@@ -62,11 +62,11 @@  discard block
 block discarded – undo
62 62
 	 * @param string|Closure $new_handler
63 63
 	 * @return null
64 64
 	 */
65
-	public function set( $new_handler ) {
66
-		$handler = $this->parse( $new_handler );
65
+	public function set($new_handler) {
66
+		$handler = $this->parse($new_handler);
67 67
 
68
-		if ( $handler === null ) {
69
-			throw new Exception( 'No or invalid handler provided.' );
68
+		if ($handler === null) {
69
+			throw new Exception('No or invalid handler provided.');
70 70
 		}
71 71
 
72 72
 		$this->handler = $handler;
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
79 79
 	 */
80 80
 	public function execute() {
81 81
 		$arguments = func_get_args();
82
-		if ( ! is_array( $this->handler ) ) {
83
-			return call_user_func_array( $this->handler, $arguments );
82
+		if ( ! is_array($this->handler)) {
83
+			return call_user_func_array($this->handler, $arguments);
84 84
 		}
85 85
 
86 86
 		$class = $this->handler['class'];
87 87
 		$method = $this->handler['method'];
88 88
 
89
-		$controller = Framework::instantiate( $class );
90
-		return call_user_func_array( [$controller, $method], $arguments );
89
+		$controller = Framework::instantiate($class);
90
+		return call_user_func_array([$controller, $method], $arguments);
91 91
 	}
92 92
 }
Please login to merge, or discard this patch.
src/Routing/Middleware/HasMiddlewareTrait.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -23,12 +23,12 @@  discard block
 block discarded – undo
23 23
 	 * @param  any     $middleware
24 24
 	 * @return boolean
25 25
 	 */
26
-	protected function isMiddleware( $middleware ) {
27
-		if ( is_callable( $middleware ) ) {
26
+	protected function isMiddleware($middleware) {
27
+		if (is_callable($middleware)) {
28 28
 			return true;
29 29
 		}
30 30
 		
31
-		if ( is_a( $middleware, MiddlewareInterface::class, true ) ) {
31
+		if (is_a($middleware, MiddlewareInterface::class, true)) {
32 32
 			return true;
33 33
 		}
34 34
 
@@ -50,16 +50,16 @@  discard block
 block discarded – undo
50 50
 	 * @param  string|callable|\CarbonFramework\Routing\Middleware\MiddlewareInterface|array $middleware
51 51
 	 * @return object
52 52
 	 */
53
-	public function addMiddleware( $middleware ) {
54
-		$middleware = is_array( $middleware ) ? $middleware : [$middleware];
53
+	public function addMiddleware($middleware) {
54
+		$middleware = is_array($middleware) ? $middleware : [$middleware];
55 55
 
56
-		foreach ( $middleware as $item ) {
57
-			if ( ! $this->isMiddleware( $item ) ) {
58
-				throw new Exception( 'Passed middleware must be a callable or the name of a class which implements the ' . MiddlewareInterface::class . ' interface.' );
56
+		foreach ($middleware as $item) {
57
+			if ( ! $this->isMiddleware($item)) {
58
+				throw new Exception('Passed middleware must be a callable or the name of a class which implements the ' . MiddlewareInterface::class . ' interface.');
59 59
 			}
60 60
 		}
61 61
 
62
-		$this->middleware = array_merge( $this->getMiddleware(), $middleware );
62
+		$this->middleware = array_merge($this->getMiddleware(), $middleware);
63 63
 		return $this;
64 64
 	}
65 65
 
@@ -69,8 +69,8 @@  discard block
 block discarded – undo
69 69
 	 * @param  string|callable|\CarbonFramework\Routing\Middleware\MiddlewareInterface|array $middleware
70 70
 	 * @return object
71 71
 	 */
72
-	public function add( $middleware ) {
73
-		return $this->addMiddleware( $middleware );
72
+	public function add($middleware) {
73
+		return $this->addMiddleware($middleware);
74 74
 	}
75 75
 
76 76
 	/**
@@ -81,22 +81,22 @@  discard block
 block discarded – undo
81 81
 	 * @param  Closure                                                   $next
82 82
 	 * @return ResponseInterface
83 83
 	 */
84
-	public function executeMiddleware( $middleware, $request, Closure $next ) {
85
-		$top_middleware = array_pop( $middleware );
84
+	public function executeMiddleware($middleware, $request, Closure $next) {
85
+		$top_middleware = array_pop($middleware);
86 86
 
87
-		if ( $top_middleware === null ) {
88
-			return $next( $request );
87
+		if ($top_middleware === null) {
88
+			return $next($request);
89 89
 		}
90 90
 
91
-		$top_middleware_next = function( $request ) use ( $middleware, $next ) {
92
-			return $this->executeMiddleware( $middleware, $request, $next );
91
+		$top_middleware_next = function($request) use ($middleware, $next) {
92
+			return $this->executeMiddleware($middleware, $request, $next);
93 93
 		};
94 94
 
95
-		if ( is_callable( $top_middleware ) ) {
96
-			return call_user_func( $top_middleware, $request, $top_middleware_next );
95
+		if (is_callable($top_middleware)) {
96
+			return call_user_func($top_middleware, $request, $top_middleware_next);
97 97
 		}
98 98
 
99 99
 		$instance = new $top_middleware();
100
-		return $instance->handle( $request, $top_middleware_next );
100
+		return $instance->handle($request, $top_middleware_next);
101 101
 	}
102 102
 }
Please login to merge, or discard this patch.
src/ServiceProviders/OldInput.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -12,22 +12,22 @@
 block discarded – undo
12 12
 	/**
13 13
 	 * {@inheritDoc}
14 14
 	 */
15
-	public function register( $container ) {
16
-		$container['framework.global_middleware'] = array_merge( $container['framework.global_middleware'], [
15
+	public function register($container) {
16
+		$container['framework.global_middleware'] = array_merge($container['framework.global_middleware'], [
17 17
 			OldInputMiddleware::class,
18
-		] );
18
+		]);
19 19
 
20 20
 		$container['framework.old_input.old_input'] = function() {
21 21
 			return new \CarbonFramework\Input\OldInput();
22 22
 		};
23 23
 
24
-		Framework::facade( 'OldInput', \CarbonFramework\Facades\OldInput::class );
24
+		Framework::facade('OldInput', \CarbonFramework\Facades\OldInput::class);
25 25
 	}
26 26
 
27 27
 	/**
28 28
 	 * {@inheritDoc}
29 29
 	 */
30
-	public function boot( $container ) {
30
+	public function boot($container) {
31 31
 		// nothing to boot
32 32
 	}
33 33
 }
34 34
\ No newline at end of file
Please login to merge, or discard this patch.
src/ServiceProviders/Templating.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * {@inheritDoc}
13 13
 	 */
14
-	public function register( $container ) {
14
+	public function register($container) {
15 15
 		$container['framework.templating.engine'] = function() {
16 16
 			return new \CarbonFramework\Templating\Php();
17 17
 		};
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	/**
21 21
 	 * {@inheritDoc}
22 22
 	 */
23
-	public function boot( $container ) {
23
+	public function boot($container) {
24 24
 		// nothing to boot
25 25
 	}
26 26
 }
27 27
\ No newline at end of file
Please login to merge, or discard this patch.
src/ServiceProviders/Routing.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * {@inheritDoc}
13 13
 	 */
14
-	public function register( $container ) {
15
-		$container['framework.config'] = array_merge( [
14
+	public function register($container) {
15
+		$container['framework.config'] = array_merge([
16 16
 			'global_middleware' => [],
17
-		], $container['framework.config'] );
17
+		], $container['framework.config']);
18 18
 
19 19
 		$container['framework.global_middleware'] = $container['framework.config']['global_middleware'];
20
-		$container['framework.global_middleware'] = apply_filters( 'carbon_framework_global_middleware', $container['framework.global_middleware'] );
20
+		$container['framework.global_middleware'] = apply_filters('carbon_framework_global_middleware', $container['framework.global_middleware']);
21 21
 
22 22
 		$container['framework.routing.conditions.custom'] = \CarbonFramework\Routing\Conditions\Custom::class;
23 23
 		$container['framework.routing.conditions.url'] = \CarbonFramework\Routing\Conditions\Url::class;
@@ -30,13 +30,13 @@  discard block
 block discarded – undo
30 30
 			return new \CarbonFramework\Routing\Router();
31 31
 		};
32 32
 
33
-		Framework::facade( 'Router', \CarbonFramework\Facades\Router::class );
33
+		Framework::facade('Router', \CarbonFramework\Facades\Router::class);
34 34
 	}
35 35
 
36 36
 	/**
37 37
 	 * {@inheritDoc}
38 38
 	 */
39
-	public function boot( $container ) {
39
+	public function boot($container) {
40 40
 		\Router::boot(); // facade
41 41
 	}
42 42
 }
43 43
\ No newline at end of file
Please login to merge, or discard this patch.
src/Flash/Flash.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -26,12 +26,12 @@  discard block
 block discarded – undo
26 26
 	 * 
27 27
 	 * @param array|\ArrayAccess $storage
28 28
 	 */
29
-	public function __construct( &$storage ) {
30
-		if ( $this->isValidStorage( $storage ) ) {
31
-			if ( ! isset( $storage[ $this->storage_key ] ) ) {
32
-				$storage[ $this->storage_key ] = [];
29
+	public function __construct(&$storage) {
30
+		if ($this->isValidStorage($storage)) {
31
+			if ( ! isset($storage[$this->storage_key])) {
32
+				$storage[$this->storage_key] = [];
33 33
 			}
34
-			$this->storage = &$storage[ $this->storage_key ];
34
+			$this->storage = &$storage[$this->storage_key];
35 35
 		}
36 36
 	}
37 37
 
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	 * @param  any     $storage
42 42
 	 * @return boolean
43 43
 	 */
44
-	protected function isValidStorage( $storage ) {
44
+	protected function isValidStorage($storage) {
45 45
 		return $storage !== null;
46 46
 	}
47 47
 
@@ -52,8 +52,8 @@  discard block
 block discarded – undo
52 52
 	 * @return null
53 53
 	 */
54 54
 	protected function validateStorage() {
55
-		if ( ! $this->isValidStorage( $this->storage ) ) {
56
-			throw new Exception( 'Attempted to use Flash without an active session. Did you forget to call session_start()?' );
55
+		if ( ! $this->isValidStorage($this->storage)) {
56
+			throw new Exception('Attempted to use Flash without an active session. Did you forget to call session_start()?');
57 57
 		}
58 58
 	}
59 59
 
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 	 * @return boolean
64 64
 	 */
65 65
 	public function enabled() {
66
-		return $this->isValidStorage( $this->storage );
66
+		return $this->isValidStorage($this->storage);
67 67
 	}
68 68
 
69 69
 	/**
@@ -72,11 +72,11 @@  discard block
 block discarded – undo
72 72
 	 * @param  string|null $key
73 73
 	 * @return array
74 74
 	 */
75
-	public function get( $key = null ) {
75
+	public function get($key = null) {
76 76
 		$this->validateStorage();
77 77
 
78
-		$items = $this->peek( $key );
79
-		$this->clear( $key );
78
+		$items = $this->peek($key);
79
+		$this->clear($key);
80 80
 		return $items;
81 81
 	}
82 82
 
@@ -86,15 +86,15 @@  discard block
 block discarded – undo
86 86
 	 * @param  string|null $key
87 87
 	 * @return array|\ArrayAccess
88 88
 	 */
89
-	public function peek( $key = null ) {
89
+	public function peek($key = null) {
90 90
 		$this->validateStorage();
91 91
 		
92
-		if ( $key === null ) {
92
+		if ($key === null) {
93 93
 			return $this->storage;
94 94
 		}
95 95
 		
96
-		if ( isset( $this->storage[ $key ] ) ) {
97
-			return $this->storage[ $key ];
96
+		if (isset($this->storage[$key])) {
97
+			return $this->storage[$key];
98 98
 		}
99 99
 
100 100
 		return [];
@@ -106,18 +106,18 @@  discard block
 block discarded – undo
106 106
 	 * @param string    $key
107 107
 	 * @param any|array $new_items
108 108
 	 */
109
-	public function add( $key, $new_items ) {
109
+	public function add($key, $new_items) {
110 110
 		$this->validateStorage();
111 111
 		
112
-		$new_items = is_array( $new_items ) ? $new_items : [$new_items];
112
+		$new_items = is_array($new_items) ? $new_items : [$new_items];
113 113
 
114
-		$items = $this->peek( $key );
115
-		$items = array_merge( $items, $new_items );
114
+		$items = $this->peek($key);
115
+		$items = array_merge($items, $new_items);
116 116
 		
117
-		if ( $key === null ) {
117
+		if ($key === null) {
118 118
 			$this->storage = $items;
119 119
 		} else {
120
-			$this->storage[ $key ] = $items;
120
+			$this->storage[$key] = $items;
121 121
 		}
122 122
 	}
123 123
 
@@ -127,13 +127,13 @@  discard block
 block discarded – undo
127 127
 	 * @param  string|null $key
128 128
 	 * @return null
129 129
 	 */
130
-	public function clear( $key = null ) {
130
+	public function clear($key = null) {
131 131
 		$this->validateStorage();
132 132
 		
133
-		if ( $key === null ) {
133
+		if ($key === null) {
134 134
 			$this->storage = [];
135 135
 		} else {
136
-			$this->storage[ $key ] = [];
136
+			$this->storage[$key] = [];
137 137
 		}
138 138
 	}
139 139
 }
140 140
\ No newline at end of file
Please login to merge, or discard this patch.