Number_Field::to_json() - Code Metrics - Inspection of "Add carbon field number" - htmlburger/carbon-fields - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#77)

unknown

created 2016-08-18 10:53 UTC

Number_Field::to_json() A

↳ Parent: Number_Field

Complexity

Conditions	4
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	4
eloc	7
c	1
b	0
f	1
nc	1
nop	1
dl	0
loc	11
rs	9.2

<?php

namespace Carbon_Fields\Field;

/**
 * Number field class.
 */
class Number_Field extends Field {

	protected $default_min = 1;
	protected $default_max = 2147483647;
	protected $default_step = 1;

	protected $min = 1;
	protected $max = 2147483647;
	protected $step = 1;

	/**
	 * Underscore template of this field.
	 */
	function template() {

		?>
		<input id="{{{ id }}}" type="number" name="{{{ name }}}" value="{{ value }}" class="regular-text" />
		<?php
	}

	function to_json($load) {

		$field_data = parent::to_json($load);


		$field_data = array_merge($field_data, array(
			'min' => is_numeric($this->min) ? $this->min : $this->default_min,

			'max' => is_numeric($this->max) ? $this->max : $this->default_max,

			'step' => is_numeric($this->step) ? $this->step : $this->default_step,

		));

		return $field_data;
	}

	function save() {

		$name = $this->get_name();
		$value = $this->get_value();

		// Set the value for the field
		$this->set_name($name);


		$field_value = '';
		if ( isset($value) && $value !== '' && is_numeric($value) ) {

			$value = floatval($value);


			$is_valid_min = $this->min <= $value;
			$is_valid_max = $value <= $this->max;

			if ( $value !== '' && $is_valid_min && $is_valid_max ) {

				$field_value = $value;
			}
		}

		$this->set_value($field_value);


		parent::save();
	}

	function set_max($max) {

		$this->max = $max;
		return $this;
	}

	function set_min($min) {

		$this->min = $min;
		return $this;
	}

	function set_step($step) {

		$this->step = $step;
		return $this;
	}
}

1			<?php
2
3			namespace Carbon_Fields\Field;
4
5			/**
6			* Number field class.
7			*/
8			class Number_Field extends Field {
9
10			protected $default_min = 1;
11			protected $default_max = 2147483647;
12			protected $default_step = 1;
13
14			protected $min = 1;
15			protected $max = 2147483647;
16			protected $step = 1;
17
18			/**
19			* Underscore template of this field.
20			*/
21			function template() {
			0 ignored issues – show Best Practice introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
22			?>
23			<input id="{{{ id }}}" type="number" name="{{{ name }}}" value="{{ value }}" class="regular-text" />
24			<?php
25			}
26
27			function to_json($load) {
			0 ignored issues – show Best Practice introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28			$field_data = parent::to_json($load);
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
29
30			$field_data = array_merge($field_data, array(
31			'min' => is_numeric($this->min) ? $this->min : $this->default_min,
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
32			'max' => is_numeric($this->max) ? $this->max : $this->default_max,
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
33			'step' => is_numeric($this->step) ? $this->step : $this->default_step,
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
34			));
35
36			return $field_data;
37			}
38
39			function save() {
			0 ignored issues – show Best Practice introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
40			$name = $this->get_name();
41			$value = $this->get_value();
42
43			// Set the value for the field
44			$this->set_name($name);
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
45
46			$field_value = '';
47			if ( isset($value) && $value !== '' && is_numeric($value) ) {
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
48			$value = floatval($value);
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
49
50			$is_valid_min = $this->min <= $value;
51			$is_valid_max = $value <= $this->max;
52
53			if ( $value !== '' && $is_valid_min && $is_valid_max ) {
			0 ignored issues – show Unused Code Bug introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report The strict comparison `!==` seems to always evaluate to `true` as the types of `$value` (`double`) and `''` (`string`) can never be identical. Maybe you want to use a loose comparison `!=` instead? Loading history...
54			$field_value = $value;
55			}
56			}
57
58			$this->set_value($field_value);
			0 ignored issues – show Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
59
60			parent::save();
61			}
62
63			function set_max($max) {
			0 ignored issues – show Best Practice introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
64			$this->max = $max;
65			return $this;
66			}
67
68			function set_min($min) {
			0 ignored issues – show Best Practice introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
69			$this->min = $min;
70			return $this;
71			}
72
73			function set_step($step) {
			0 ignored issues – show Best Practice introduced 2016-08-18 11:06 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
74			$this->step = $step;
75			return $this;
76			}
77			}

htmlburger / carbon-fields

Pull Request — master (#77)

Number_Field::to_json() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like