Carbon_Fields\Field\Number_Field

Complexity

Total Complexity

15

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	template()	0	5	1
A	to_json()	0	11	4
C	save()	0	23	7
A	set_max()	0	4	1
A	set_min()	0	4	1
A	set_step()	0	4	1

<?php

namespace Carbon_Fields\Field;

/**
 * Number field class.
 */
class Number_Field extends Field {

	protected $default_min = 1;
	protected $default_max = 2147483647;
	protected $default_step = 1;

	protected $min = 1;
	protected $max = 2147483647;
	protected $step = 1;

	/**
	 * Underscore template of this field.
	 */
	function template() {

It is generally recommended to explicitly declare the visibility for methods.

		?>
		<input id="{{{ id }}}" type="number" name="{{{ name }}}" value="{{ value }}" class="regular-text" />
		<?php
	}

	function to_json($load) {

It is generally recommended to explicitly declare the visibility for methods.

		$field_data = parent::to_json($load);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$field_data = array_merge($field_data, array(
			'min' => is_numeric($this->min) ? $this->min : $this->default_min,

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			'max' => is_numeric($this->max) ? $this->max : $this->default_max,

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			'step' => is_numeric($this->step) ? $this->step : $this->default_step,

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		));

		return $field_data;
	}

	function save() {

It is generally recommended to explicitly declare the visibility for methods.

		$name = $this->get_name();
		$value = $this->get_value();

		// Set the value for the field
		$this->set_name($name);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$field_value = '';
		if ( isset($value) && $value !== '' && is_numeric($value) ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$value = floatval($value);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$is_valid_min = $this->min <= $value;
			$is_valid_max = $value <= $this->max;

			if ( $value !== '' && $is_valid_min && $is_valid_max ) {

The strict comparison !== seems to always evaluate to true as the types of $value (double) and '' (string) can never be identical. Maybe you want to use a loose comparison != instead?

				$field_value = $value;
			}
		}

		$this->set_value($field_value);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		parent::save();
	}

	function set_max($max) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->max = $max;
		return $this;
	}

	function set_min($min) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->min = $min;
		return $this;
	}

	function set_step($step) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->step = $step;
		return $this;
	}
}