GaufretteLoader::__construct() - Code Metrics - hrevert/HtImgModule - Measure and Improve Code Quality continuously with Scrutinizer

GaufretteLoader::__construct() A
last analyzed 2018-04-27 19:04 UTC

↳ Parent: GaufretteLoader

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
ccs	3
cts	3
cp	1
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php
namespace HtImgModule\Imagine\Loader;

use Gaufrette\Filesystem;
use Gaufrette\Exception\FileNotFound as FileNotFoundException;
use HtImgModule\Exception;
use HtImgModule\Binary\Binary;

/**
 * Image Loader for Library, Gaufrette
 * @see https://github.com/KnpLabs/Gaufrette
 */
class GaufretteLoader implements LoaderInterface
{
    /**
     * @var Filesystem
     */
    protected $filesystem;

    /**
     * Constructor
     *
     * @param Filesystem $filesystem
     */
    public function __construct(Filesystem $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * {@inheritDoc}
     */
    public function load($path)
    {
        try {
            $contents = $this->filesystem->read($path);

        } catch (FileNotFoundException $e) {
            throw new Exception\ImageNotFoundException(sprintf('Source image not found in "%s"', $path));
        }

        try {
            $mimeType = $this->filesystem->mimeType($path);
        } catch (\LogicException $e) {
            // Mime Type could not be detected
            return $contents;
        }

        if (!$mimeType) {
            // Mime Type could not be detected
            return $contents;
        }

        return new Binary($contents, $mimeType);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1		<?php
2		namespace HtImgModule\Imagine\Loader;
3
4		use Gaufrette\Filesystem;
5		use Gaufrette\Exception\FileNotFound as FileNotFoundException;
6		use HtImgModule\Exception;
7		use HtImgModule\Binary\Binary;
8
9		/**
10		* Image Loader for Library, Gaufrette
11		* @see https://github.com/KnpLabs/Gaufrette
12		*/
13		class GaufretteLoader implements LoaderInterface
14		{
15		/**
16		* @var Filesystem
17		*/
18		protected $filesystem;
19
20		/**
21		* Constructor
22		*
23		* @param Filesystem $filesystem
24		*/
25	4	public function __construct(Filesystem $filesystem)
26		{
27	4	$this->filesystem = $filesystem;
28	4	}
29
30		/**
31		* {@inheritDoc}
32		*/
33	4	public function load($path)
34		{
35		try {
36	4	$contents = $this->filesystem->read($path);
		0 ignored issues – show Bug Compatibility introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report The expression `$this->filesystem->read($path);` of type `string\|boolean` adds the type `boolean` to the return on line 45 which is incompatible with the return type declared by the interface `HtImgModule\Imagine\Loader\LoaderInterface::load` of type `HtImgModule\Binary\Binary\|string`. Loading history...
37	1	} catch (FileNotFoundException $e) {
38	1	throw new Exception\ImageNotFoundException(sprintf('Source image not found in "%s"', $path));
39		}
40
41		try {
42	3	$mimeType = $this->filesystem->mimeType($path);
43	1	} catch (\LogicException $e) {
44		// Mime Type could not be detected
45	1	return $contents;
46		}
47
48	2	if (!$mimeType) {
49		// Mime Type could not be detected
50	1	return $contents;
51		}
52
53	1	return new Binary($contents, $mimeType);
		0 ignored issues – show Bug introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report It seems like `$contents` defined by `$this->filesystem->read($path)` on line `36` can also be of type `boolean`; however, `HtImgModule\Binary\Binary::__construct()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
54		}
55		}
56

hrevert / HtImgModule

GitHub Access Token became invalid

GaufretteLoader::__construct() A last analyzed 2018-04-27 19:04 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

GaufretteLoader::__construct() A
last analyzed 2018-04-27 19:04 UTC