HtImgModule\Imagine\Loader\GaufretteLoader

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	load()	0	22	4

<?php
namespace HtImgModule\Imagine\Loader;

use Gaufrette\Filesystem;
use Gaufrette\Exception\FileNotFound as FileNotFoundException;
use HtImgModule\Exception;
use HtImgModule\Binary\Binary;

/**
 * Image Loader for Library, Gaufrette
 * @see https://github.com/KnpLabs/Gaufrette
 */
class GaufretteLoader implements LoaderInterface
{
    /**
     * @var Filesystem
     */
    protected $filesystem;

    /**
     * Constructor
     *
     * @param Filesystem $filesystem
     */
    public function __construct(Filesystem $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * {@inheritDoc}
     */
    public function load($path)
    {
        try {
            $contents = $this->filesystem->read($path);

The expression $this->filesystem->read($path); of type string|boolean adds the type boolean to the return on line 45 which is incompatible with the return type declared by the interface HtImgModule\Imagine\Loader\LoaderInterface::load of type HtImgModule\Binary\Binary|string.

        } catch (FileNotFoundException $e) {
            throw new Exception\ImageNotFoundException(sprintf('Source image not found in "%s"', $path));
        }

        try {
            $mimeType = $this->filesystem->mimeType($path);
        } catch (\LogicException $e) {
            // Mime Type could not be detected
            return $contents;
        }

        if (!$mimeType) {
            // Mime Type could not be detected
            return $contents;
        }

        return new Binary($contents, $mimeType);

It seems like $contents defined by $this->filesystem->read($path) on line 36 can also be of type boolean; however, HtImgModule\Binary\Binary::__construct() does only seem to accept string, maybe add an additional type check?

    }
}