Issues in SecureWebRequest.class.php (master) - Issues in master - horros/agavi2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1131)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/request/SecureWebRequest.class.php (17 issues)

Labels

Coding Style 17

Severity

Minor 17

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Agavi\Request;

// +---------------------------------------------------------------------------+
// | This file is part of the Agavi package.                                   |
// | Copyright (c) 2005-2011 the Agavi Project.                                |
// |                                                                           |
// | For the full copyright and license information, please view the LICENSE   |
// | file that was distributed with this source code. You can also view the    |
// | LICENSE file online at http://www.agavi.org/LICENSE.txt                   |
// |   vi: set noexpandtab:                                                    |
// |   Local Variables:                                                        |
// |   indent-tabs-mode: t                                                     |
// |   End:                                                                    |
// +---------------------------------------------------------------------------+

/**
 * SecureWebRequest provides additional support for HTTPS client requests
 * such as SSL certificate inspection.
 *
 * @package    agavi
 * @subpackage request
 *
 * @author     Markus Lervik <[email protected]>
 * @author     David Zülke <[email protected]>
 * @copyright  Authors
 * @copyright  The Agavi Project
 *
 * @since      0.10.0.0
 *
 * @deprecated To be removed in Agavi 1.1
 *
 * @version    $Id$
 */
class SecureWebRequest extends WebRequest
{

    /**
     * Check whether or not the current request is over a secure connection
     * (HTTPS)
     *
     * @return     bool true if HTTPS is on, false otherwise
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function isHTTPS()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        return (isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on');
    }

    /**
     * Check if the client certificate is a valid one
     *
     * @return     bool true if the certificate is valid, false otherwise
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function hasValidClientCert()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        return (isset($_SERVER['SSL_CLIENT_VERIFY']) && strtoupper($_SERVER['SSL_CLIENT_VERIFY']) == 'SUCCESS');
    }

// -------------------------------------------------------------------------

    /**
     * Get the client CN (Common Name) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the CN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertCN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_CN'])) {
            return $_SERVER['SSL_CLIENT_S_DN_CN'];
        }
    }

// -------------------------------------------------------------------------

    /**
     * Get the client DN (Distinguished Name) field from the client X.509
     * certificate if one is available
     *
     * @return     mixed the DN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertDN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN'])) {
            return $_SERVER['SSL_CLIENT_S_DN'];
        }
    }

    /**
     * Get the client GN (General Name) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the GN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertGN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_G'])) {
            return $_SERVER['SSL_CLIENT_S_DN_G'];
        }
    }

    /**
     * Get the client SN (Subject Name) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the SN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertSN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_S'])) {
            return $_SERVER['SSL_CLIENT_S_DN_S'];
        }
    }

    /**
     * Get the client O (Organisation) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the O field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertO()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_O'])) {
            return $_SERVER['SSL_CLIENT_S_DN_O'];
        }
    }

    /**
     * Get the client OU (Organisation Unit) field from the client X.509
     * certificate if one is available
     *
     * @return     mixed the OU field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertOU()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_OU'])) {
            return $_SERVER['SSL_CLIENT_S_DN_OU'];
        }
    }

    /**
     * Get the date from which the client certificate is valid
     * if one is available
     *
     * @return     mixed the date field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertValidityStart()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_V_START'])) {
            return $_SERVER['SSL_CLIENT_V_START'];
        }
    }

    /**
     * Get the date until which the client certificate is valid
     * if one is available
     *
     * @return     mixed the date field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertValidityEnd()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_V_END'])) {
            return $_SERVER['SSL_CLIENT_V_END'];
        }
    }

    /**
     * Get the cipher type used for this connection
     * if one is available
     *
     * @return     mixed the cipher type if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getSSLChipherType()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CIPHER'])) {
            return $_SERVER['SSL_CIPHER'];
        }
    }

    /**
     * Get the issuer DN (Distinguished Name) field from the issuer X.509
     * certificate if one is available
     *
     * @return     mixed the DN field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertDN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_DN'])) {
            return $_SERVER['SSL_CLIENT_I_DN'];
        }
    }

    /**
     * Get the issuer CN (Common Name) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the CN field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertCN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_CN'])) {
            return $_SERVER['SSL_CLIENT_I_CN'];
        }
    }

    /**
     * Get the issuer C (Country) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the C field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertC()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_C'])) {
            return $_SERVER['SSL_CLIENT_I_C'];
        }
    }

    /**
     * Get the issuer O (Organisation) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the O field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertO()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_O'])) {
            return $_SERVER['SSL_CLIENT_I_O'];
        }
    }

    /**
     * Get the issuer OU (Organisation Unit) field from the issuer X.509
     * certificate if one is available
     *
     * @return     mixed the OU field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertOU()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_OU'])) {
            return $_SERVER['SSL_CLIENT_I_OU'];
        }
    }

    /**
     * Get the issuer ST (State) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the ST field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0.0
     */
    public function getIssuerCertST()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_ST'])) {
            return $_SERVER['SSL_CLIENT_I_ST'];
        }
    }
}


horros / agavi2

Issues (1131)

Security Analysis not enabled

src/request/SecureWebRequest.class.php (17 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like