SecureWebRequest - Code Metrics - horros/agavi2 - Measure and Improve Code Quality continuously with Scrutinizer

SecureWebRequest A
last analyzed 2017-05-30 13:20 UTC

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	300
Duplicated Lines	0 %
Coupling/Cohesion

Components	0
Dependencies	1
Importance

Changes
Metric	Value
dl	0
loc	300
rs	9.2
c	0
b	0
f	0
wmc	34
lcom	0
cbo	1
17 Methods

Rating	Name	Size	Complexity
A	isHTTPS()	5	2
A	hasValidClientCert()	5	2
A	getClientCertCN()	7	2
A	getClientCertDN()	7	2
A	getClientCertGN()	7	2
A	getClientCertSN()	7	2
A	getClientCertO()	7	2
A	getClientCertOU()	7	2
A	getClientCertValidityStart()	7	2
A	getClientCertValidityEnd()	7	2
A	getSSLChipherType()	7	2
A	getIssuerCertDN()	7	2
A	getIssuerCertCN()	7	2
A	getIssuerCertC()	7	2
A	getIssuerCertO()	7	2
A	getIssuerCertOU()	7	2
A	getIssuerCertST()	7	2
<?php
namespace Agavi\Request;

// +---------------------------------------------------------------------------+
// | This file is part of the Agavi package.                                   |
// | Copyright (c) 2005-2011 the Agavi Project.                                |
// |                                                                           |
// | For the full copyright and license information, please view the LICENSE   |
// | file that was distributed with this source code. You can also view the    |
// | LICENSE file online at http://www.agavi.org/LICENSE.txt                   |
// |   vi: set noexpandtab:                                                    |
// |   Local Variables:                                                        |
// |   indent-tabs-mode: t                                                     |
// |   End:                                                                    |
// +---------------------------------------------------------------------------+

/**
 * SecureWebRequest provides additional support for HTTPS client requests
 * such as SSL certificate inspection.
 *
 * @package    agavi
 * @subpackage request
 *
 * @author     Markus Lervik <[email protected]>
 * @author     David Zülke <[email protected]>
 * @copyright  Authors
 * @copyright  The Agavi Project
 *
 * @since      0.10.0.0
 *
 * @deprecated To be removed in Agavi 1.1
 *
 * @version    $Id$
 */
class SecureWebRequest extends WebRequest
{

    /**
     * Check whether or not the current request is over a secure connection
     * (HTTPS)
     *
     * @return     bool true if HTTPS is on, false otherwise
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function isHTTPS()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        return (isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on');
    }

    /**
     * Check if the client certificate is a valid one
     *
     * @return     bool true if the certificate is valid, false otherwise
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function hasValidClientCert()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        return (isset($_SERVER['SSL_CLIENT_VERIFY']) && strtoupper($_SERVER['SSL_CLIENT_VERIFY']) == 'SUCCESS');
    }

// -------------------------------------------------------------------------

    /**
     * Get the client CN (Common Name) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the CN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertCN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_CN'])) {
            return $_SERVER['SSL_CLIENT_S_DN_CN'];
        }
    }

// -------------------------------------------------------------------------

    /**
     * Get the client DN (Distinguished Name) field from the client X.509
     * certificate if one is available
     *
     * @return     mixed the DN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertDN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN'])) {
            return $_SERVER['SSL_CLIENT_S_DN'];
        }
    }

    /**
     * Get the client GN (General Name) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the GN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertGN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_G'])) {
            return $_SERVER['SSL_CLIENT_S_DN_G'];
        }
    }

    /**
     * Get the client SN (Subject Name) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the SN field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertSN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_S'])) {
            return $_SERVER['SSL_CLIENT_S_DN_S'];
        }
    }

    /**
     * Get the client O (Organisation) field from the client X.509 certificate
     * if one is available
     *
     * @return     mixed the O field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertO()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_O'])) {
            return $_SERVER['SSL_CLIENT_S_DN_O'];
        }
    }

    /**
     * Get the client OU (Organisation Unit) field from the client X.509
     * certificate if one is available
     *
     * @return     mixed the OU field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertOU()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_S_DN_OU'])) {
            return $_SERVER['SSL_CLIENT_S_DN_OU'];
        }
    }

    /**
     * Get the date from which the client certificate is valid
     * if one is available
     *
     * @return     mixed the date field if it's available, otherwise null
     *
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertValidityStart()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_V_START'])) {
            return $_SERVER['SSL_CLIENT_V_START'];
        }
    }

    /**
     * Get the date until which the client certificate is valid
     * if one is available
     *
     * @return     mixed the date field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getClientCertValidityEnd()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_V_END'])) {
            return $_SERVER['SSL_CLIENT_V_END'];
        }
    }

    /**
     * Get the cipher type used for this connection
     * if one is available
     *
     * @return     mixed the cipher type if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getSSLChipherType()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CIPHER'])) {
            return $_SERVER['SSL_CIPHER'];
        }
    }

    /**
     * Get the issuer DN (Distinguished Name) field from the issuer X.509
     * certificate if one is available
     *
     * @return     mixed the DN field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertDN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_DN'])) {
            return $_SERVER['SSL_CLIENT_I_DN'];
        }
    }

    /**
     * Get the issuer CN (Common Name) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the CN field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertCN()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_CN'])) {
            return $_SERVER['SSL_CLIENT_I_CN'];
        }
    }

    /**
     * Get the issuer C (Country) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the C field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertC()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_C'])) {
            return $_SERVER['SSL_CLIENT_I_C'];
        }
    }

    /**
     * Get the issuer O (Organisation) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the O field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertO()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_O'])) {
            return $_SERVER['SSL_CLIENT_I_O'];
        }
    }

    /**
     * Get the issuer OU (Organisation Unit) field from the issuer X.509
     * certificate if one is available
     *
     * @return     mixed the OU field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0
     */
    public function getIssuerCertOU()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_OU'])) {
            return $_SERVER['SSL_CLIENT_I_OU'];
        }
    }

    /**
     * Get the issuer ST (State) field from the issuer X.509 certificate
     * if one is available
     *
     * @return     mixed the ST field if it's available, otherwise null
     * @author     Markus Lervik <[email protected]>
     * @author     David Zülke <[email protected]>
     * @since      0.10.0.0
     */
    public function getIssuerCertST()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (isset($_SERVER['SSL_CLIENT_I_ST'])) {
            return $_SERVER['SSL_CLIENT_I_ST'];
        }
    }
}

horros / agavi2

SecureWebRequest A last analyzed 2017-05-30 13:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

17 Methods

Duplication Side-by-Side

Filter issues like

SecureWebRequest A
last analyzed 2017-05-30 13:20 UTC
