Completed
Push — master ( d95bde...2ad848 )
by Markus
07:09
created
src/date/TimeZoneDataParser.class.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -554,7 +554,7 @@  discard block
 block discarded – undo
554 554
      * @param      int $gmtOff The gmt offset.
555 555
      * @param      int $dstOff The dst offset.
556 556
      *
557
-     * @return     int The unix timestamp.
557
+     * @return     double The unix timestamp.
558 558
      *
559 559
      * @author     Dominik del Bondio <[email protected]>
560 560
      * @since      0.11.0
@@ -1049,7 +1049,7 @@  discard block
 block discarded – undo
1049 1049
      *
1050 1050
      * @param      string $date The date as string.
1051 1051
      *
1052
-     * @return     array The parts of the date.
1052
+     * @return     integer The parts of the date.
1053 1053
      *
1054 1054
      * @author     Dominik del Bondio <[email protected]>
1055 1055
      * @since      0.11.0
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -65,9 +65,9 @@  discard block
 block discarded – undo
65 65
         $this->context = $context;
66 66
     }
67 67
 
68
-    const MIN_GEN_YEAR   =  1900;
69
-    const MAX_GEN_YEAR   =  2040;
70
-    const MAX_YEAR_VALUE =  2147483647;
68
+    const MIN_GEN_YEAR   = 1900;
69
+    const MAX_GEN_YEAR   = 2040;
70
+    const MAX_YEAR_VALUE = 2147483647;
71 71
     const MIN_YEAR_VALUE = -2147483647;
72 72
 
73 73
     /**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 
127 127
         $zoneLines = explode("\n", $data);
128 128
         // filter comments
129
-        $zoneLines = array_filter($zoneLines, function ($line) {
129
+        $zoneLines = array_filter($zoneLines, function($line) {
130 130
             return !(strlen(trim($line)) == 0 || preg_match('!^\s*#!', $line));
131 131
         });
132 132
 
@@ -630,7 +630,7 @@  discard block
 block discarded – undo
630 630
                 $lastChar = true;
631 631
                 $cNext = null;
632 632
             } else {
633
-                $cNext = $line[$i+1];
633
+                $cNext = $line[$i + 1];
634 634
             }
635 635
             $c = $line[$i];
636 636
 
@@ -788,7 +788,7 @@  discard block
 block discarded – undo
788 788
 
789 789
         $month = $this->getMonthFromAbbr($ruleColumns[4]);
790 790
         if (!is_numeric($month)) {
791
-            throw new AgaviException('Unknown month "'.$month.'" in rule ' . $name);
791
+            throw new AgaviException('Unknown month "' . $month . '" in rule ' . $name);
792 792
         }
793 793
 
794 794
         $on = $ruleColumns[5];
@@ -797,14 +797,14 @@  discard block
 block discarded – undo
797 797
         } elseif (preg_match('!^last(.*)$!', $on, $match)) {
798 798
             $day = $this->getDayFromAbbr($match[1]);
799 799
             if (!is_numeric($day)) {
800
-                throw new AgaviException('Unknown day "'.$day.'" in rule ' . $name);
800
+                throw new AgaviException('Unknown day "' . $day . '" in rule ' . $name);
801 801
             }
802 802
 
803 803
             $on = array('type' => 'last', 'date' => null, 'day' => $day);
804 804
         } elseif (preg_match('!^([a-z]+)(\>\=|\<\=)([0-9]+)$!i', $on, $match)) {
805 805
             $day = $this->getDayFromAbbr($match[1]);
806 806
             if (!is_numeric($day)) {
807
-                throw new AgaviException('Unknown day "'.$day.'" in rule ' . $name);
807
+                throw new AgaviException('Unknown day "' . $day . '" in rule ' . $name);
808 808
             }
809 809
 
810 810
             $on = array('type' => $match[2], 'date' => $match[3], 'day' => $day);
Please login to merge, or discard this patch.
src/testing/PhpUnitTestCase.class.php 3 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -58,6 +58,7 @@
 block discarded – undo
58 58
      * @param        string
59 59
      * @param        array
60 60
      * @param        string
61
+     * @param string $name
61 62
      *
62 63
      * @since        1.1.0
63 64
      */
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -301,7 +301,7 @@
 block discarded – undo
301 301
      *
302 302
      * @author       Felix Gilcher <[email protected]>
303 303
      * @since        1.0.2
304
-    */
304
+     */
305 305
     protected function prepareTemplate(\Text_Template $template)
306 306
     {
307 307
         parent::prepareTemplate($template);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -269,16 +269,16 @@
 block discarded – undo
269 269
         // FIXME: added by phpunit 4.x
270 270
         if (class_exists('\PHPUnit_Util_Blacklist')) {
271 271
             $blacklist = new \PHPUnit\Util\Blacklist;
272
-            $isBlacklisted = function ($file) use ($testFile, $blacklist) {
272
+            $isBlacklisted = function($file) use ($testFile, $blacklist) {
273 273
                 return $file === $testFile || $blacklist->isBlacklisted($file);
274 274
             };
275 275
         } elseif (is_callable(array('\PHPUnit_Util_GlobalState', 'phpunitFiles'))) {
276 276
             $blacklist = \PHPUnit_Util_GlobalState::phpunitFiles();
277
-            $isBlacklisted = function ($file) use ($testFile, $blacklist) {
277
+            $isBlacklisted = function($file) use ($testFile, $blacklist) {
278 278
                 return $file === $testFile || isset($blacklist[$file]);
279 279
             };
280 280
         } else {
281
-            $isBlacklisted = function ($file) use ($testFile) {
281
+            $isBlacklisted = function($file) use ($testFile) {
282 282
                 return $file === $testFile;
283 283
             };
284 284
         }
Please login to merge, or discard this patch.
src/util/Toolkit.class.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
     /**
319 319
      * Replace configuration directive identifiers in a string.
320 320
      *
321
-     * @param      string $valute The value on which to run the replacement procedure.
321
+     * @param      string $value The value on which to run the replacement procedure.
322 322
      *
323 323
      * @return     string The new value.
324 324
      *
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
      * @param      int   $denominator The denominator.
350 350
      * @param      int   $remainder   The remainder.
351 351
      *
352
-     * @return     int   The floored quotient.
352
+     * @return     double   The floored quotient.
353 353
      *
354 354
      * @author     Dominik del Bondio <[email protected]>
355 355
      * @since      0.11.0
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
             $oldvalue = $value;
332 332
             $value = preg_replace_callback(
333 333
                 '/\%([\w\.]+?)\%/',
334
-                function ($matches) {
334
+                function($matches) {
335 335
                     return Config::get($matches[1], '%' . $matches[1] . '%');
336 336
                 },
337 337
                 $value
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
             throw new AgaviException('Toolkit::floorDivide works only for int denominators');
361 361
         }
362 362
         $quotient = floor($numerator / $denominator);
363
-        $remainder = (int) ($numerator - ($quotient * $denominator));
363
+        $remainder = (int)($numerator - ($quotient * $denominator));
364 364
 
365 365
         return $quotient;
366 366
     }
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
     public static function stripNamespace($className)
545 545
     {
546 546
         if (false !== ($slashpos = strrpos($className, '\\'))) {
547
-            $className = substr($className, (strrpos($className, '\\')+1));
547
+            $className = substr($className, (strrpos($className, '\\') + 1));
548 548
         }
549 549
         return $className;
550 550
     }
Please login to merge, or discard this patch.
src/testing/PhpUnitCli.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
             ));
243 243
             // ensure that the execution order of the tests is always in deterministic
244 244
             // order and doesn't depend on the filesystem order
245
-            usort($files, function ($a, $b) {
245
+            usort($files, function($a, $b) {
246 246
                 return strcmp($a->getPathName(), $b->getPathName());
247 247
             });
248 248
 
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
         // bootstrap the framework for autoload, config handlers etc.
332 332
         Agavi::bootstrap($environment);
333 333
 
334
-        ini_set('include_path', get_include_path().PATH_SEPARATOR.dirname(__DIR__));
334
+        ini_set('include_path', get_include_path() . PATH_SEPARATOR . dirname(__DIR__));
335 335
         
336 336
         $GLOBALS['AGAVI_CONFIG'] = Config::toArray();
337 337
     }
Please login to merge, or discard this patch.