hirak / prestissimo

src/Aspects/HttpGetRequest.php

Doc Comments +8 added lines

@@ -60,6 +60,9 @@ 
         }
     }
 
+    /**
+     * @param string $url
+     */
     public function importURL($url)
     {
         $struct = parse_url($url);
@@ -78,6 +81,11 @@ 
     }
 
     // utility for __construct
+
+    /**
+     * @param string $key
+     * @param string $default
+     */
     private static function setOr(array $struct, $key, $default=null)
     {
         if (!empty($struct[$key])) {

Spacing +4 added lines, -4 removed lines

@@ -63,7 +63,7 @@ 
     public function importURL($url)
     {
         $struct = parse_url($url);
-        if (! $struct) throw new \InvalidArgumentException("$url is not valid URL");
+        if (!$struct) throw new \InvalidArgumentException("$url is not valid URL");
 
         $this->scheme = self::setOr($struct, 'scheme', $this->scheme);
         $this->host = self::setOr($struct, 'host', $this->host);
@@ -72,13 +72,13 @@ 
         $this->username = self::setOr($struct, 'user', null);
         $this->password = self::setOr($struct, 'pass', null);
 
-        if (! empty($struct['query'])) {
+        if (!empty($struct['query'])) {
             parse_str($struct['query'], $this->query);
         }
     }
 
     // utility for __construct
-    private static function setOr(array $struct, $key, $default=null)
+    private static function setOr(array $struct, $key, $default = null)
     {
         if (!empty($struct[$key])) {
             return $struct[$key];
@@ -98,7 +98,7 @@ 
             CURLOPT_USERAGENT => $this->genUA(),
         );
 
-        $curlOpts[CURLOPT_VERBOSE] = (bool) $this->verbose;
+        $curlOpts[CURLOPT_VERBOSE] = (bool)$this->verbose;
 
         if ($this->username && $this->password) {
             $curlOpts[CURLOPT_USERPWD] = "$this->username:$this->password";

Braces +6 added lines, -2 removed lines

@@ -63,7 +63,9 @@ 
     public function importURL($url)
     {
         $struct = parse_url($url);
-        if (! $struct) throw new \InvalidArgumentException("$url is not valid URL");
+        if (! $struct) {
+            throw new \InvalidArgumentException("$url is not valid URL");
+        }
 
         $this->scheme = self::setOr($struct, 'scheme', $this->scheme);
         $this->host = self::setOr($struct, 'host', $this->host);
@@ -149,7 +151,9 @@ 
 
     public static function genUA() {
         static $ua;
-        if ($ua) return $ua;
+        if ($ua) {
+            return $ua;
+        }
         $phpVersion = defined('HHVM_VERSION') ? 'HHVM ' . HHVM_VERSION : 'PHP ' . PHP_VERSION;
 
         return $ua = sprintf(

src/CurlRemoteFilesystem.php

Doc Comments +9 added lines, -1 removed lines

@@ -79,7 +79,7 @@ 
     /**
      * Get the content.
      *
-     * @param string $originUrl The origin URL
+     * @param string $origin The origin URL
      * @param string $fileUrl   The file URL
      * @param bool   $progress  Display the progression
      * @param array  $options   Additional context options
@@ -97,6 +97,11 @@ 
         });
     }
 
+    /**
+     * @param string $fileUrl
+     * @param boolean $progress
+     * @param \Closure $exec
+     */
     protected function fetch($origin, $fileUrl, $progress, $options, $exec)
     {
         do {
@@ -216,6 +221,9 @@ 
         return 0;
     }
 
+    /**
+     * @param string $fileName
+     */
     public static function createFile($fileName)
     {
         if (is_dir($fileName)) {

Spacing +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
      *
      * @return bool true
      */
-    public function copy($origin, $fileUrl, $fileName, $progress=true, $options=array())
+    public function copy($origin, $fileUrl, $fileName, $progress = true, $options = array())
     {
         return $this->fetch($origin, $fileUrl, $progress, $options, function($ch, $request) use($fileName){
             $fp = $this->createFile($fileName);
@@ -86,9 +86,9 @@ 
      *
      * @return bool|string The content
      */
-    public function getContents($origin, $fileUrl, $progress=true, $options=array())
+    public function getContents($origin, $fileUrl, $progress = true, $options = array())
     {
-        return $this->fetch($origin, $fileUrl, $progress, $options, function($ch, $request){
+        return $this->fetch($origin, $fileUrl, $progress, $options, function($ch, $request) {
             // This order is important.
             curl_setopt($ch, CURLOPT_FILE, STDOUT);
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

src/Plugin.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use Composer\Plugin as CPlugin;
 use Composer\EventDispatcher;
 use Composer\Package;
-
 use Composer\Installer;
 use Composer\DependencyResolver;
 

Spacing +5 added lines, -5 removed lines

@@ -107,7 +107,7 @@ 
         }
 
         $config = $this->config->get('prestissimo');
-        if (! is_array($config)) {
+        if (!is_array($config)) {
             $config = array();
         }
         $config += array(
@@ -118,16 +118,16 @@ 
             'privatePackages' => array(),
         );
 
-        if (! is_int($config['maxConnections']) || $config['maxConnections'] < 1) {
+        if (!is_int($config['maxConnections']) || $config['maxConnections'] < 1) {
             $config['maxConnections'] = 6;
         }
-        if (! is_int($config['minConnections']) || $config['minConnections'] > $config['maxConnections']) {
+        if (!is_int($config['minConnections']) || $config['minConnections'] > $config['maxConnections']) {
             $config['minConnections'] = 3;
         }
-        if (! is_bool($config['pipeline'])) {
+        if (!is_bool($config['pipeline'])) {
             $config['pipeline'] = (bool)$config['pipeline'];
         }
-        if (! is_array($config['privatePackages'])) {
+        if (!is_array($config['privatePackages'])) {
             $config['privatePackages'] = (array)$config['privatePackages'];
         }
 

src/Factory.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
      * @param bool $auth
      * @return resource<curl>
      */
-    public static function getConnection($origin, $auth=false)
+    public static function getConnection($origin, $auth = false)
     {
         $instance = self::getInstance();
         if ($auth) {

Indentation +4 added lines, -4 removed lines

@@ -1,9 +1,9 @@
 <?php
 /**
- * hirak/prestissimo
- * @author Hiraku NAKANO
- * @license MIT https://github.com/hirak/prestissimo
- */
+     * hirak/prestissimo
+     * @author Hiraku NAKANO
+     * @license MIT https://github.com/hirak/prestissimo
+     */
 namespace Hirak\Prestissimo;
 
 /**

src/ParallelDownloader.php

Braces +15 added lines, -8 removed lines

@@ -110,24 +110,31 @@
             }
 
             // start multi download
-            do $stat = curl_multi_exec($mh, $running);
-            while ($stat === CURLM_CALL_MULTI_PERFORM);
+            do {
+                $stat = curl_multi_exec($mh, $running);
+            } while ($stat === CURLM_CALL_MULTI_PERFORM);
 
             // wait for any event
-            do switch (curl_multi_select($mh, 5)) {
+            do {
+                switch (curl_multi_select($mh, 5)) {
                 case -1:
                     usleep(10);
-                    do $stat = curl_multi_exec($mh, $running);
-                    while ($stat === CURLM_CALL_MULTI_PERFORM);
+            }
+                    do {
+                        $stat = curl_multi_exec($mh, $running);
+                    } while ($stat === CURLM_CALL_MULTI_PERFORM);
                     continue 2;
                 case 0:
                     continue 2;
                 default:
-                    do $stat = curl_multi_exec($mh, $running);
-                    while ($stat === CURLM_CALL_MULTI_PERFORM);
+                    do {
+                        $stat = curl_multi_exec($mh, $running);
+                    } while ($stat === CURLM_CALL_MULTI_PERFORM);
 
-                    do if ($raised = curl_multi_info_read($mh, $remains)) {
+                    do {
+                        if ($raised = curl_multi_info_read($mh, $remains)) {
                         $ch = $raised['handle'];
+                    }
                         $errno = curl_errno($ch);
                         $info = curl_getinfo($ch);
                         curl_setopt($ch, CURLOPT_FILE, STDOUT);