hirak / prestissimo

src/Aspects/HttpGetRequest.php

Doc Comments +8 added lines

@@ -60,6 +60,9 @@ 
         }
     }
 
+    /**
+     * @param string $url
+     */
     public function importURL($url)
     {
         $struct = parse_url($url);
@@ -78,6 +81,11 @@ 
     }
 
     // utility for __construct
+
+    /**
+     * @param string $key
+     * @param string $default
+     */
     private static function setOr(array $struct, $key, $default=null)
     {
         if (!empty($struct[$key])) {

Spacing +4 added lines, -4 removed lines

@@ -63,7 +63,7 @@ 
     public function importURL($url)
     {
         $struct = parse_url($url);
-        if (! $struct) {
+        if (!$struct) {
             throw new \InvalidArgumentException("$url is not valid URL");
         }
 
@@ -74,13 +74,13 @@ 
         $this->username = self::setOr($struct, 'user', null);
         $this->password = self::setOr($struct, 'pass', null);
 
-        if (! empty($struct['query'])) {
+        if (!empty($struct['query'])) {
             parse_str($struct['query'], $this->query);
         }
     }
 
     // utility for __construct
-    private static function setOr(array $struct, $key, $default=null)
+    private static function setOr(array $struct, $key, $default = null)
     {
         if (!empty($struct[$key])) {
             return $struct[$key];
@@ -100,7 +100,7 @@ 
             CURLOPT_USERAGENT => $this->genUA(),
         );
 
-        $curlOpts[CURLOPT_VERBOSE] = (bool) $this->verbose;
+        $curlOpts[CURLOPT_VERBOSE] = (bool)$this->verbose;
 
         if ($this->username && $this->password) {
             $curlOpts[CURLOPT_USERPWD] = "$this->username:$this->password";

src/Factory.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
      * @param bool $auth
      * @return resource<curl>
      */
-    public static function getConnection($origin, $auth=false)
+    public static function getConnection($origin, $auth = false)
     {
         $instance = self::getInstance();
         if ($auth) {

Indentation +4 added lines, -4 removed lines

@@ -1,9 +1,9 @@
 <?php
 /**
- * hirak/prestissimo
- * @author Hiraku NAKANO
- * @license MIT https://github.com/hirak/prestissimo
- */
+     * hirak/prestissimo
+     * @author Hiraku NAKANO
+     * @license MIT https://github.com/hirak/prestissimo
+     */
 namespace Hirak\Prestissimo;
 
 /**

src/Plugin.php

Spacing +7 added lines, -7 removed lines

@@ -107,7 +107,7 @@ 
         }
 
         $config = $this->config->get('prestissimo');
-        if (! is_array($config)) {
+        if (!is_array($config)) {
             $config = array();
         }
         $config += array(
@@ -120,22 +120,22 @@ 
             'privatePackages' => array(),
         );
 
-        if (! is_int($config['maxConnections']) || $config['maxConnections'] < 1) {
+        if (!is_int($config['maxConnections']) || $config['maxConnections'] < 1) {
             $config['maxConnections'] = 6;
         }
-        if (! is_int($config['minConnections']) || $config['minConnections'] > $config['maxConnections']) {
+        if (!is_int($config['minConnections']) || $config['minConnections'] > $config['maxConnections']) {
             $config['minConnections'] = 3;
         }
-        if (! is_bool($config['pipeline'])) {
+        if (!is_bool($config['pipeline'])) {
             $config['pipeline'] = (bool)$config['pipeline'];
         }
-        if (! is_bool($config['insecure'])) {
+        if (!is_bool($config['insecure'])) {
             $config['insecure'] = (bool)$config['insecure'];
         }
-        if (! is_string($config['capath'])) {
+        if (!is_string($config['capath'])) {
             $config['capath'] = '';
         }
-        if (! is_array($config['privatePackages'])) {
+        if (!is_array($config['privatePackages'])) {
             $config['privatePackages'] = (array)$config['privatePackages'];
         }
 

src/OutputFile.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
             fclose($this->fp);
         }
 
-        if (! $this->success) {
+        if (!$this->success) {
             unlink($this->fileName);
             foreach ($this->createdDirs as $dir) {
                 rmdir($dir);
@@ -74,7 +74,7 @@ 
         do {
             $dir = dirname($dir);
             $createdDirs[] = $dir;
-        } while (! file_exists($dir));
+        } while (!file_exists($dir));
         array_pop($createdDirs);
         $this->createdDirs = array_reverse($createdDirs);
 

src/CurlRemoteFilesystem.php

Doc Comments +6 added lines

@@ -108,6 +108,12 @@
         });
     }
 
+    /**
+     * @param string $origin
+     * @param string $fileUrl
+     * @param boolean $progress
+     * @param \Closure $exec
+     */
     protected function fetch($origin, $fileUrl, $progress, $options, $exec)
     {
         do {

Spacing +9 added lines, -9 removed lines

@@ -64,11 +64,11 @@ 
      *
      * @return bool true
      */
-    public function copy($origin, $fileUrl, $fileName, $progress=true, $options=array())
+    public function copy($origin, $fileUrl, $fileName, $progress = true, $options = array())
     {
         $that = $this; // for PHP5.3
 
-        return $this->fetch($origin, $fileUrl, $progress, $options, function ($ch, $request) use ($that, $fileName) {
+        return $this->fetch($origin, $fileUrl, $progress, $options, function($ch, $request) use ($that, $fileName) {
             $outputFile = new OutputFile($fileName);
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, false);
             curl_setopt($ch, CURLOPT_FILE, $outputFile->getPointer());
@@ -95,11 +95,11 @@ 
      *
      * @return bool|string The content
      */
-    public function getContents($origin, $fileUrl, $progress=true, $options=array())
+    public function getContents($origin, $fileUrl, $progress = true, $options = array())
     {
         $that = $this; // for PHP5.3
 
-        return $this->fetch($origin, $fileUrl, $progress, $options, function ($ch, $request) use ($that) {
+        return $this->fetch($origin, $fileUrl, $progress, $options, function($ch, $request) use ($that) {
             // This order is important.
             curl_setopt($ch, CURLOPT_FILE, STDOUT);
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
@@ -154,16 +154,16 @@ 
             if ($this->pluginConfig['insecure']) {
                 $opts[CURLOPT_SSL_VERIFYPEER] = false;
             }
-            if (! empty($pluginConfig['userAgent'])) {
+            if (!empty($pluginConfig['userAgent'])) {
                 $opts[CURLOPT_USERAGENT] = $pluginConfig['userAgent'];
             }
-            if (! empty($pluginConfig['capath'])) {
+            if (!empty($pluginConfig['capath'])) {
                 $opts[CURLOPT_CAPATH] = $pluginConfig['capath'];
             }
 
             curl_setopt_array($ch, $opts);
 
-            list($execStatus, ) = $exec($ch, $request);
+            list($execStatus,) = $exec($ch, $request);
         } while ($this->_retry);
 
         if ($progress) {
@@ -227,9 +227,9 @@ 
     {
         // @codeCoverageIgnoreStart
         if (PHP_VERSION_ID >= 50500) {
-            list(, $downBytesMax, $downBytes, , ) = func_get_args();
+            list(, $downBytesMax, $downBytes,,) = func_get_args();
         } else {
-            list($downBytesMax, $downBytes, , ) = func_get_args();
+            list($downBytesMax, $downBytes,,) = func_get_args();
         }
         // @codeCoverageIgnoreEnd
 

src/ParallelDownloader.php

Switch Indentation +33 added lines, -33 removed lines

@@ -122,41 +122,41 @@
                 } while ($stat === CURLM_CALL_MULTI_PERFORM);
 
                 switch (curl_multi_select($mh, 5)) {
-                case -1:
-                    usleep(250);
-                    // fall through
-                case 0:
-                    continue 2;
-                default:
-                    do {
-                        $stat = curl_multi_exec($mh, $running);
-                    } while ($stat === CURLM_CALL_MULTI_PERFORM);
-
-                    do {
-                        if ($raised = curl_multi_info_read($mh, $remains)) {
-                            $ch = $raised['handle'];
-                            $errno = curl_errno($ch);
-                            $info = curl_getinfo($ch);
-                            curl_setopt($ch, CURLOPT_FILE, STDOUT);
-                            $index = (int)$ch;
-                            $outputFile = $chFpMap[$index];
-                            unset($chFpMap[$index]);
-                            if (CURLE_OK === $errno && 200 === $info['http_code']) {
-                                ++$this->successCnt;
-                            } else {
-                                ++$this->failureCnt;
-                                $outputFile->setFailure();
+                    case -1:
+                        usleep(250);
+                        // fall through
+                    case 0:
+                        continue 2;
+                    default:
+                        do {
+                            $stat = curl_multi_exec($mh, $running);
+                        } while ($stat === CURLM_CALL_MULTI_PERFORM);
+
+                        do {
+                            if ($raised = curl_multi_info_read($mh, $remains)) {
+                                $ch = $raised['handle'];
+                                $errno = curl_errno($ch);
+                                $info = curl_getinfo($ch);
+                                curl_setopt($ch, CURLOPT_FILE, STDOUT);
+                                $index = (int)$ch;
+                                $outputFile = $chFpMap[$index];
+                                unset($chFpMap[$index]);
+                                if (CURLE_OK === $errno && 200 === $info['http_code']) {
+                                    ++$this->successCnt;
+                                } else {
+                                    ++$this->failureCnt;
+                                    $outputFile->setFailure();
+                                }
+                                unset($outputFile);
+                                $this->io->write($this->makeDownloadingText($info['url']));
+                                curl_multi_remove_handle($mh, $ch);
+                                $unused[] = $ch;
                             }
-                            unset($outputFile);
-                            $this->io->write($this->makeDownloadingText($info['url']));
-                            curl_multi_remove_handle($mh, $ch);
-                            $unused[] = $ch;
-                        }
-                    } while ($remains > 0);
+                        } while ($remains > 0);
 
-                    if (count($packages) > 0) {
-                        break 2;
-                    }
+                        if (count($packages) > 0) {
+                            break 2;
+                        }
                 }
             } while ($running);
         } while (count($packages) > 0);

Spacing +2 added lines, -2 removed lines

@@ -104,10 +104,10 @@
                 if ($pluginConfig['insecure']) {
                     $opts[CURLOPT_SSL_VERIFYPEER] = false;
                 }
-                if (! empty($pluginConfig['userAgent'])) {
+                if (!empty($pluginConfig['userAgent'])) {
                     $opts[CURLOPT_USERAGENT] = $pluginConfig['userAgent'];
                 }
-                if (! empty($pluginConfig['capath'])) {
+                if (!empty($pluginConfig['capath'])) {
                     $opts[CURLOPT_CAPATH] = $pluginConfig['capath'];
                 }
                 unset($opts[CURLOPT_ENCODING]);