Completed
Pull Request — master (#66)
by Jan
05:29
created
src/Config.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         $validator = new JsonSchema\Validator;
31 31
         $validator->check((object)$config, json_decode($schema));
32 32
 
33
-        if (! $validator->isValid()) {
33
+        if (!$validator->isValid()) {
34 34
             throw new \InvalidArgumentException(var_export($validator->getErrors(), true));
35 35
         }
36 36
 
Please login to merge, or discard this patch.
src/Aspects/HttpGetRequest.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     {
61 61
         $struct = parse_url($url);
62 62
         // @codeCoverageIgnoreStart
63
-        if (! $struct) {
63
+        if (!$struct) {
64 64
             throw new \InvalidArgumentException("$url is not valid URL");
65 65
         }
66 66
         // @codeCoverageIgnoreEnd
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $this->username = self::setOr($struct, 'user', null);
73 73
         $this->password = self::setOr($struct, 'pass', null);
74 74
 
75
-        if (! empty($struct['query'])) {
75
+        if (!empty($struct['query'])) {
76 76
             parse_str($struct['query'], $this->query);
77 77
         }
78 78
     }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -187,6 +187,7 @@
 block discarded – undo
187 187
 
188 188
     /**
189 189
      * @internal
190
+     * @param integer $privateCode
190 191
      */
191 192
     public function promptAuthWithUtil($privateCode, $util, HttpGetResponse $res, IO\IOInterface $io)
192 193
     {
Please login to merge, or discard this patch.
src/CurlRemoteFilesystem.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     {
68 68
         $that = $this; // for PHP5.3
69 69
 
70
-        return $this->fetch($origin, $fileUrl, $progress, $options, function ($ch, $request) use ($that, $fileName) {
70
+        return $this->fetch($origin, $fileUrl, $progress, $options, function($ch, $request) use ($that, $fileName) {
71 71
             $outputFile = new OutputFile($fileName);
72 72
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, false);
73 73
             curl_setopt($ch, CURLOPT_FILE, $outputFile->getPointer());
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
     {
99 99
         $that = $this; // for PHP5.3
100 100
 
101
-        return $this->fetch($origin, $fileUrl, $progress, $options, function ($ch, $request) use ($that) {
101
+        return $this->fetch($origin, $fileUrl, $progress, $options, function($ch, $request) use ($that) {
102 102
             // This order is important.
103 103
             curl_setopt($ch, CURLOPT_FILE, STDOUT);
104 104
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
Please login to merge, or discard this patch.
src/Factory.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -83,6 +83,10 @@
 block discarded – undo
83 83
         return $request;
84 84
     }
85 85
 
86
+    /**
87
+     * @param string $origin
88
+     * @param CConfig $config
89
+     */
86 90
     private static function getRequestClass($origin, $config)
87 91
     {
88 92
         if (in_array($origin, $config->get('github-domains') ?: array())) {
Please login to merge, or discard this patch.