Completed
Push — master ( 370758...236fa5 )
by Andrii
02:39
created
src/AbstractQuantity.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -198,7 +198,6 @@
 block discarded – undo
198 198
      * Returns unit for given unit name.
199 199
      * The only function to change in child classes.
200 200
      * XXX Should be defined as abstract but `abstract static` is not supported in PHP5.
201
-     * @param string $name
202 201
      * @throws InvalidConfigException
203 202
      * @return UnitInterface
204 203
      */
Please login to merge, or discard this patch.
src/UnitInterface.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,6 @@
 block discarded – undo
61 61
     /**
62 62
      * Converts to other unit quantity.
63 63
      * @param UnitInterface $other
64
-     * @param int|float|string $amount raw amount
65 64
      * @return int|float|string quantity
66 65
      */
67 66
     public function convert(self $other, $quantity);
Please login to merge, or discard this patch.
tests/unit/UnitTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -86,6 +86,9 @@
 block discarded – undo
86 86
         $this->assertConvert(1000000000, $this->bps, $this->gbps);
87 87
     }
88 88
 
89
+    /**
90
+     * @param integer $factor
91
+     */
89 92
     protected function assertConvert($factor, Unit $lesser, Unit $bigger)
90 93
     {
91 94
         $this->assertSame(1, $lesser->convert($lesser, 1));
Please login to merge, or discard this patch.