Issues in YandexP2pMerchant.php - New Issues - Inspection of "quickfixed epayservice test: changed check_key" - hiqdev/php-merchant - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 259fd8...a43b07 )

by Andrii

created 2017-11-26 11:12 UTC

src/merchants/yandex/YandexP2pMerchant.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Generalization over Omnipay and Payum
 *
 * @link      https://github.com/hiqdev/php-merchant
 * @package   php-merchant
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\merchant\merchants\yandex;

use hiqdev\php\merchant\InvoiceInterface;
use hiqdev\php\merchant\merchants\AbstractMerchant;
use hiqdev\php\merchant\response\CompletePurchaseResponse;
use hiqdev\php\merchant\response\RedirectPurchaseResponse;
use Omnipay\YandexMoney\P2pGateway;

/**
 * Class YandexP2pMerchant.
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class YandexP2pMerchant extends AbstractMerchant
{
    /**
     * @var P2pGateway
     */
    protected $gateway;

    protected function createGateway()
    {
        return $this->gatewayFactory->build('YandexMoney_P2p', [
            'account' => $this->credentials->getPurse(),
            'password' => $this->credentials->getKey1(),
            'testMode' => $this->credentials->isTestMode(),
        ]);
    }

    /**
     * @param InvoiceInterface $invoice
     * @return RedirectPurchaseResponse
     */
    public function requestPurchase(InvoiceInterface $invoice)
    {
        /**
         * @var \Omnipay\YandexMoney\Message\p2p\PurchaseResponse
         */
        $response = $this->gateway->purchase([
            'transactionId' => $invoice->getId(),
            'description' => $invoice->getDescription(),
            'amount' => $this->moneyFormatter->format($invoice->getAmount()),
            'currency' => $invoice->getCurrency()->getCode(),
            'returnUrl' => $invoice->getReturnUrl(),
            'notifyUrl' => $invoice->getNotifyUrl(),
            'cancelUrl' => $invoice->getCancelUrl(),
            'method' => 'PC', // https://money.yandex.ru/doc.xml?id=526991
        ])->send();

        return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
    }

    /**
     * @param array $data
     * @return CompletePurchaseResponse
     */
    public function completePurchase($data)
    {
        /** @var \Omnipay\YandexMoney\Message\p2p\CompletePurchaseResponse $response */
        $response = $this->gateway->completePurchase($data)->send();

        return (new CompletePurchaseResponse())
            ->setIsSuccessful($response->isSuccessful())
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
            ->setTransactionReference($response->getTransactionReference())
            ->setTransactionId($response->getTransactionId())
            ->setPayer($response->getData()['sender'] ?? $response->getData()['email'] ?? '')
            ->setTime(
                (new \DateTime($response->getTime(), new \DateTimeZone('Europe/Moscow')))
                    ->setTimezone(new \DateTimeZone('UTC'))
            );
    }
}


1			<?php
2			/**
3			* Generalization over Omnipay and Payum
4			*
5			* @link https://github.com/hiqdev/php-merchant
6			* @package php-merchant
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\merchant\merchants\yandex;
12
13			use hiqdev\php\merchant\InvoiceInterface;
14			use hiqdev\php\merchant\merchants\AbstractMerchant;
15			use hiqdev\php\merchant\response\CompletePurchaseResponse;
16			use hiqdev\php\merchant\response\RedirectPurchaseResponse;
17			use Omnipay\YandexMoney\P2pGateway;
18
19			/**
20			* Class YandexP2pMerchant.
21			*
22			* @author Dmytro Naumenko <[email protected]>
23			*/
24			class YandexP2pMerchant extends AbstractMerchant
25			{
26			/**
27			* @var P2pGateway
28			*/
29			protected $gateway;
30
31	3		protected function createGateway()
32			{
33	3		return $this->gatewayFactory->build('YandexMoney_P2p', [
34	3		'account' => $this->credentials->getPurse(),
35	3		'password' => $this->credentials->getKey1(),
36	3		'testMode' => $this->credentials->isTestMode(),
37			]);
38			}
39
40			/**
41			* @param InvoiceInterface $invoice
42			* @return RedirectPurchaseResponse
43			*/
44	1		public function requestPurchase(InvoiceInterface $invoice)
45			{
46			/**
47			* @var \Omnipay\YandexMoney\Message\p2p\PurchaseResponse
48			*/
49	1		$response = $this->gateway->purchase([
50	1		'transactionId' => $invoice->getId(),
51	1		'description' => $invoice->getDescription(),
52	1		'amount' => $this->moneyFormatter->format($invoice->getAmount()),
53	1		'currency' => $invoice->getCurrency()->getCode(),
54	1		'returnUrl' => $invoice->getReturnUrl(),
55	1		'notifyUrl' => $invoice->getNotifyUrl(),
56	1		'cancelUrl' => $invoice->getCancelUrl(),
57	1		'method' => 'PC', // https://money.yandex.ru/doc.xml?id=526991
58	1		])->send();
59
60	1		return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
61			}
62
63			/**
64			* @param array $data
65			* @return CompletePurchaseResponse
66			*/
67	1	View Code Duplication	public function completePurchase($data)
68			{
69			/** @var \Omnipay\YandexMoney\Message\p2p\CompletePurchaseResponse $response */
70	1		$response = $this->gateway->completePurchase($data)->send();
71
72	1		return (new CompletePurchaseResponse())
73	1		->setIsSuccessful($response->isSuccessful())
			0 ignored issues – show Documentation introduced 2017-11-26 11:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$response->isSuccessful()` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74	1		->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
75	1		->setTransactionReference($response->getTransactionReference())
76	1		->setTransactionId($response->getTransactionId())
77	1		->setPayer($response->getData()['sender'] ?? $response->getData()['email'] ?? '')
78	1		->setTime(
79	1		(new \DateTime($response->getTime(), new \DateTimeZone('Europe/Moscow')))
80	1		->setTimezone(new \DateTimeZone('UTC'))
81			);
82			}
83			}
84

hiqdev / php-merchant

Push — master ( 259fd8...a43b07 )

src/merchants/yandex/YandexP2pMerchant.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like