Completed
Push — master ( 259fd8...a43b07 )
by Andrii
03:33
created

YandexP2pMerchant::createGateway()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 8
Code Lines 5

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 5
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 8
ccs 5
cts 5
cp 1
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 5
nc 1
nop 0
crap 1
1
<?php
2
/**
3
 * Generalization over Omnipay and Payum
4
 *
5
 * @link      https://github.com/hiqdev/php-merchant
6
 * @package   php-merchant
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hiqdev\php\merchant\merchants\yandex;
12
13
use hiqdev\php\merchant\InvoiceInterface;
14
use hiqdev\php\merchant\merchants\AbstractMerchant;
15
use hiqdev\php\merchant\response\CompletePurchaseResponse;
16
use hiqdev\php\merchant\response\RedirectPurchaseResponse;
17
use Omnipay\YandexMoney\P2pGateway;
18
19
/**
20
 * Class YandexP2pMerchant.
21
 *
22
 * @author Dmytro Naumenko <[email protected]>
23
 */
24
class YandexP2pMerchant extends AbstractMerchant
25
{
26
    /**
27
     * @var P2pGateway
28
     */
29
    protected $gateway;
30
31 3
    protected function createGateway()
32
    {
33 3
        return $this->gatewayFactory->build('YandexMoney_P2p', [
34 3
            'account' => $this->credentials->getPurse(),
35 3
            'password' => $this->credentials->getKey1(),
36 3
            'testMode' => $this->credentials->isTestMode(),
37
        ]);
38
    }
39
40
    /**
41
     * @param InvoiceInterface $invoice
42
     * @return RedirectPurchaseResponse
43
     */
44 1
    public function requestPurchase(InvoiceInterface $invoice)
45
    {
46
        /**
47
         * @var \Omnipay\YandexMoney\Message\p2p\PurchaseResponse
48
         */
49 1
        $response = $this->gateway->purchase([
50 1
            'transactionId' => $invoice->getId(),
51 1
            'description' => $invoice->getDescription(),
52 1
            'amount' => $this->moneyFormatter->format($invoice->getAmount()),
53 1
            'currency' => $invoice->getCurrency()->getCode(),
54 1
            'returnUrl' => $invoice->getReturnUrl(),
55 1
            'notifyUrl' => $invoice->getNotifyUrl(),
56 1
            'cancelUrl' => $invoice->getCancelUrl(),
57 1
            'method' => 'PC', // https://money.yandex.ru/doc.xml?id=526991
58 1
        ])->send();
59
60 1
        return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
61
    }
62
63
    /**
64
     * @param array $data
65
     * @return CompletePurchaseResponse
66
     */
67 1 View Code Duplication
    public function completePurchase($data)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
68
    {
69
        /** @var \Omnipay\YandexMoney\Message\p2p\CompletePurchaseResponse $response */
70 1
        $response = $this->gateway->completePurchase($data)->send();
71
72 1
        return (new CompletePurchaseResponse())
73 1
            ->setIsSuccessful($response->isSuccessful())
0 ignored issues
show
Documentation introduced by
$response->isSuccessful() is of type boolean, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
74 1
            ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
75 1
            ->setTransactionReference($response->getTransactionReference())
76 1
            ->setTransactionId($response->getTransactionId())
77 1
            ->setPayer($response->getData()['sender'] ?? $response->getData()['email'] ?? '')
78 1
            ->setTime(
79 1
                (new \DateTime($response->getTime(), new \DateTimeZone('Europe/Moscow')))
80 1
                    ->setTimezone(new \DateTimeZone('UTC'))
81
            );
82
    }
83
}
84