Type::getUniqueId() - Code Metrics - Inspection of "fixed Bill to use interfaces" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3d080b...428142 )

by Andrii

created 2017-11-30 11:37 UTC

Type::getUniqueId() A

↳ Parent: Type

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	2
eloc	2
nc	2
nop	0
crap	6

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\type;

/**
 * General Type.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class Type implements TypeInterface
{
    /**
     * @var string
     */
    protected $name;

    /**
     * @var integer
     */
    protected $id;

    public function __construct($name, $id = null)
    {
        $this->name = $name;
        $this->id = $id;
    }

    /**
     * {@inheritdoc}
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return $this->name;
    }

    public function getUniqueId()
    {
        return $this->getId() ?: $this->getName();
    }

    /**
     * @return string
     */
    public function equals(TypeInterface $other)
    {
        return $this->id === null && $other->id === null
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ? (string) $this->name === (string) $other->name
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            : (string) $this->id === (string) $other->id;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function jsonSerialize()
    {
        return array_filter([
            'name' => $this->name,
            'id' => $this->id,
        ]);
    }
}


1		<?php
2		/**
3		* PHP Billing Library
4		*
5		* @link https://github.com/hiqdev/php-billing
6		* @package php-billing
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\php\billing\type;
12
13		/**
14		* General Type.
15		*
16		* @author Andrii Vasyliev <[email protected]>
17		*/
18		class Type implements TypeInterface
19		{
20		/**
21		* @var string
22		*/
23		protected $name;
24
25		/**
26		* @var integer
27		*/
28		protected $id;
29
30	7	public function __construct($name, $id = null)
31		{
32	7	$this->name = $name;
33	7	$this->id = $id;
34	7	}
35
36		/**
37		* {@inheritdoc}
38		*/
39		public function getId()
40		{
41		return $this->id;
42		}
43
44		/**
45		* {@inheritdoc}
46		*/
47	4	public function getName()
48		{
49	4	return $this->name;
50		}
51
52		public function getUniqueId()
53		{
54		return $this->getId() ?: $this->getName();
55		}
56
57		/**
58		* @return string
59		*/
60	4	public function equals(TypeInterface $other)
61		{
62	4	return $this->id === null && $other->id === null
		0 ignored issues – show Bug introduced 2017-09-10 14:07 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `hiqdev\php\billing\type\TypeInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
63	2	? (string) $this->name === (string) $other->name
		0 ignored issues – show Bug introduced 2017-09-10 14:07 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `hiqdev\php\billing\type\TypeInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
64	4	: (string) $this->id === (string) $other->id;
		0 ignored issues – show Bug introduced 2017-09-10 14:07 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `hiqdev\php\billing\type\TypeInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
65		}
66
67		public function jsonSerialize()
68		{
69		return array_filter([
70		'name' => $this->name,
71		'id' => $this->id,
72		]);
73		}
74		}
75

hiqdev / php-billing

Push — master ( 3d080b...428142 )

Type::getUniqueId() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like