hiqdev\php\billing\plan\Plan

Complexity

Total Complexity

14

Size/Duplication

Total Lines	126
Duplicated Lines	0 %

Test Coverage

Coverage

59.26%

Importance

Changes	5
Bugs	0	Features	3

13 Methods

Rating	Name	Duplication	Size	Complexity
A	getUniqueId()	0	3	1
A	setName()	0	3	1
A	hasPrices()	0	3	1
A	getId()	0	3	1
A	getPrices()	0	3	1
A	getType()	0	3	1
A	getParent()	0	3	1
A	setPrices()	0	6	2
A	jsonSerialize()	0	3	1
A	setParent()	0	3	1
A	__construct()	0	14	1
A	getName()	0	3	1
A	getSeller()	0	3	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2020, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\plan;

use hiqdev\php\billing\customer\CustomerInterface;
use hiqdev\php\billing\Exception\CannotReassignException;
use hiqdev\php\billing\price\PriceInterface;
use hiqdev\php\billing\type\TypeInterface;

/**
 * Tariff Plan.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class Plan implements PlanInterface
{
    /**
     * @var int
     */
    protected $id;

    /**
     * @var string
     */
    protected $name;

    /**
     * @var Plan|null
     */
    protected $parent;

    /**
     * @var CustomerInterface
     */
    protected $seller;

    /**
     * @var PriceInterface[]
     */
    protected $prices = [];

    /**
     * @var ?TypeInterface
     */
    protected $type;

    /**
     * @param int|string|null $id
     * @param string $name
     * @param PriceInterface[] $prices
     */
    public function __construct(
        $id,
        $name,
        CustomerInterface $seller = null,
        $prices = [],
        TypeInterface $type = null,
        PlanInterface $parent = null
    ) {
        $this->id = $id;

It seems like $id can also be of type string. However, the property $id is declared as type integer. Maybe add an additional type check?

        $this->name = $name;
        $this->seller = $seller;
        $this->prices = $prices;
        $this->type = $type;
        $this->parent = $parent;
    }

    public function getUniqueId()
    {
        return $this->getId();
    }

    /**
     * @return int|string
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    public function setName(string $name): void
    {
        $this->name = $name;
    }

    /**
     * @return CustomerInterface
     */
    public function getSeller(): ?CustomerInterface
    {
        return $this->seller;
    }

    public function getParent(): ?PlanInterface
    {
        return $this->parent;
    }

    public function hasPrices(): bool
    {
        return $this->prices !== [];
    }

    /**
     * @return PriceInterface[]
     */
    public function getPrices(): array
    {
        return $this->prices;
    }

    public function setPrices(array $prices): void
    {
        if ($this->hasPrices()) {
            throw new CannotReassignException('plan prices');
        }
        $this->prices = $prices;
    }

    public function getType(): ?TypeInterface
    {
        return $this->type ?? null;
    }

    public function setParent(PlanInterface $parent): void
    {
        $this->parent = $parent;

$parent is of type hiqdev\php\billing\plan\PlanInterface, but the property $parent was declared to be of type hiqdev\php\billing\plan\Plan|null. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    public function jsonSerialize(): array
    {
        return array_filter(get_object_vars($this));
    }
}