TargetTest::checkSingleMatch() - Code Metrics - Inspection of "changed `Target::getUniqueId`, added tests" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b41e63...77c848 )

by Andrii

created 2018-01-01 13:57 UTC

TargetTest::checkSingleMatch() A

↳ Parent: TargetTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	3

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\tests\unit\target;

use hiqdev\php\billing\target\TargetCollection;
use hiqdev\php\billing\target\Target;

/**
 * @author Andrii Vasyliev <[email protected]>
 */
class TargetTest extends \PHPUnit\Framework\TestCase
{
    protected $id1 = 1;

    protected $id2 = 2;

    protected function setUp()
    {
        $this->atarget = new Target(null,       null);
        $this->target1 = new Target($this->id1, null);
        $this->target2 = new Target($this->id2, null);
        $this->aserver = new Target(null,       'server');
        $this->server1 = new Target($this->id1, 'server');
        $this->server2 = new Target($this->id2, 'server');
        $this->servers = new TargetCollection([$this->server1, $this->server2]);
        $this->adomain = new Target(null,       'domain');
        $this->domain1 = new Target($this->id1, 'domain');
        $this->domain2 = new Target($this->id2, 'domain');
        $this->domains = new TargetCollection([$this->domain1, $this->domain2]);
    }

    protected function tearDown()
    {
    }

    public function testGetUniqueId()
    {
        $this->assertSame(':',          $this->atarget->getUniqueId());
        $this->assertSame(':1',         $this->target1->getUniqueId());
        $this->assertSame(':2',         $this->target2->getUniqueId());
        $this->assertSame('server:',    $this->aserver->getUniqueId());
        $this->assertSame('server:1',   $this->server1->getUniqueId());
        $this->assertSame('server:2',   $this->server2->getUniqueId());
    }

    public function testMatches()
    {
        $atarget = new Target(null,       null);
        $aserver = new Target(null,       'server');
        $server1 = new Target($this->id1, 'server');
        $server2 = new Target($this->id2, 'server');
        $servers = new TargetCollection([$this->server1, $this->server2]);
        $adomain = new Target(null,       'domain');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $domain1 = new Target($this->id1, 'domain');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $domain2 = new Target($this->id2, 'domain');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $domains = new TargetCollection([$this->domain1, $this->domain2]);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->checkMatches([
            $this->atarget, $atarget,
            $this->aserver, $aserver,
            $this->server1, $server1,
            $this->servers, $servers,
        ]);
        $this->checkMatches([
            $this->atarget, $atarget,
            $this->aserver, $aserver,
            $this->server2, $server2,
            $this->servers, $servers,
        ]);

        $this->checkDoesntMatch([
            $this->server1, $this->server2, $this->adomain,
        ]);

        $this->checkDoesntMatch([
            $this->domain1, $this->domain2, $this->servers,
        ]);
    }

    protected function checkDoesntMatch(array $targets)
    {
        $this->checkMatches($targets, false);
    }

    protected function checkMatches(array $targets, bool $expect = true)
    {
        foreach ($targets as $k => $v) {
            foreach ($targets as $j => $w) {
                if ($k === $j) {
                    $this->assertTrue($v->matches($w));
                } else {
                    $this->checkSingleMatch($expect, $v, $w);
                }
            }
        }
    }

    protected function checkSingleMatch(bool $expect, $lhs, $rhs)
    {
        $check = $lhs->matches($rhs);
        if ($check !== $expect) {
            var_dump('no match', $expect, $lhs, $rhs);

        }
        $this->assertSame($expect, $check);
    }
}


1			<?php
2			/**
3			* PHP Billing Library
4			*
5			* @link https://github.com/hiqdev/php-billing
6			* @package php-billing
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\billing\tests\unit\target;
12
13			use hiqdev\php\billing\target\TargetCollection;
14			use hiqdev\php\billing\target\Target;
15
16			/**
17			* @author Andrii Vasyliev <[email protected]>
18			*/
19			class TargetTest extends \PHPUnit\Framework\TestCase
20			{
21			protected $id1 = 1;
22
23			protected $id2 = 2;
24
25			protected function setUp()
26			{
27			$this->atarget = new Target(null, null);
28			$this->target1 = new Target($this->id1, null);
29			$this->target2 = new Target($this->id2, null);
30			$this->aserver = new Target(null, 'server');
31			$this->server1 = new Target($this->id1, 'server');
32			$this->server2 = new Target($this->id2, 'server');
33			$this->servers = new TargetCollection([$this->server1, $this->server2]);
34			$this->adomain = new Target(null, 'domain');
35			$this->domain1 = new Target($this->id1, 'domain');
36			$this->domain2 = new Target($this->id2, 'domain');
37			$this->domains = new TargetCollection([$this->domain1, $this->domain2]);
38			}
39
40			protected function tearDown()
41			{
42			}
43
44			public function testGetUniqueId()
45			{
46			$this->assertSame(':', $this->atarget->getUniqueId());
47			$this->assertSame(':1', $this->target1->getUniqueId());
48			$this->assertSame(':2', $this->target2->getUniqueId());
49			$this->assertSame('server:', $this->aserver->getUniqueId());
50			$this->assertSame('server:1', $this->server1->getUniqueId());
51			$this->assertSame('server:2', $this->server2->getUniqueId());
52			}
53
54			public function testMatches()
55			{
56			$atarget = new Target(null, null);
57			$aserver = new Target(null, 'server');
58			$server1 = new Target($this->id1, 'server');
59			$server2 = new Target($this->id2, 'server');
60			$servers = new TargetCollection([$this->server1, $this->server2]);
61			$adomain = new Target(null, 'domain');
			0 ignored issues – show Unused Code introduced 2017-12-30 16:54 UTC by Report Bug Copy Issue Report `$adomain` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
62			$domain1 = new Target($this->id1, 'domain');
			0 ignored issues – show Unused Code introduced 2018-01-01 13:59 UTC by Report Bug Copy Issue Report `$domain1` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
63			$domain2 = new Target($this->id2, 'domain');
			0 ignored issues – show Unused Code introduced 2018-01-01 13:59 UTC by Report Bug Copy Issue Report `$domain2` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
64			$domains = new TargetCollection([$this->domain1, $this->domain2]);
			0 ignored issues – show Unused Code introduced 2017-12-30 16:54 UTC by Report Bug Copy Issue Report `$domains` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
65
66			$this->checkMatches([
67			$this->atarget, $atarget,
68			$this->aserver, $aserver,
69			$this->server1, $server1,
70			$this->servers, $servers,
71			]);
72			$this->checkMatches([
73			$this->atarget, $atarget,
74			$this->aserver, $aserver,
75			$this->server2, $server2,
76			$this->servers, $servers,
77			]);
78
79			$this->checkDoesntMatch([
80			$this->server1, $this->server2, $this->adomain,
81			]);
82
83			$this->checkDoesntMatch([
84			$this->domain1, $this->domain2, $this->servers,
85			]);
86			}
87
88			protected function checkDoesntMatch(array $targets)
89			{
90			$this->checkMatches($targets, false);
91			}
92
93			protected function checkMatches(array $targets, bool $expect = true)
94			{
95			foreach ($targets as $k => $v) {
96			foreach ($targets as $j => $w) {
97			if ($k === $j) {
98			$this->assertTrue($v->matches($w));
99			} else {
100			$this->checkSingleMatch($expect, $v, $w);
101			}
102			}
103			}
104			}
105
106			protected function checkSingleMatch(bool $expect, $lhs, $rhs)
107			{
108			$check = $lhs->matches($rhs);
109			if ($check !== $expect) {
110			var_dump('no match', $expect, $lhs, $rhs);
			0 ignored issues – show Security Debugging Code introduced 2018-01-01 13:59 UTC by Report Bug Copy Issue Report `var_dump('no match', $expect, $lhs, $rhs);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
111			}
112			$this->assertSame($expect, $check);
113			}
114			}
115

hiqdev / php-billing

Push — master ( b41e63...77c848 )

TargetTest::checkSingleMatch() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like