hiqdev\php\billing\target\TargetCollection

Complexity

Total Complexity

18

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

71.43%

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	2
A	getIds()	0	4	1
A	getTypes()	0	4	1
A	getId()	0	4	1
A	getType()	0	4	1
A	getTarget()	0	4	1
A	getUniqueId()	0	4	1
A	matches()	0	4	1
A	checkMatches()	0	10	4
A	takeIds()	0	4	2
A	takeTypes()	0	4	2
A	jsonSerialize()	0	4	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\target;

/**
 * @see TargetInterface
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class TargetCollection implements TargetInterface
{
    /**
     * @var Target[]
     */
    protected $targets;

    protected $ids;

    protected $types;

    public function __construct(array $targets)
    {
        $this->targets = $targets;
        $ids = [];
        $types = [];
        foreach ($targets as $target) {
            $ids[] = $target->getId();
            $types[] = $target->getType();
        }
        $this->ids = array_unique(array_filter($ids));
        $this->types = array_unique(array_filter($types));
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->getTarget()->getId();
    }

    public function getIds()
    {
        return $this->ids;
    }

    /**
     * {@inheritdoc}
     */
    public function getType()
    {
        return $this->getTarget()->getType();
    }

    public function getTypes()
    {
        return $this->types;
    }

    public function getTarget()
    {
        return reset($this->targets);
    }

    /**
     * @return string
     */
    public function getUniqueId()
    {
        return implode(':', array_filter([$this->getType(), $this->getId()]));
    }

    /**
     * @return bool
     */
    public function matches(TargetInterface $other): bool
    {
        return $this->checkMatches($other);
    }

    public function checkMatches(TargetInterface $other): bool
    {
        foreach ($this->targets as $target) {
            if ($target->checkMatches($other) || $other->checkMatches($target)) {
                return true;
            }
        }

        return false;
    }

    public static function takeIds(TargetInterface $other)
    {
        return $other instanceof static ? $other->ids : [$other->getId()];

Accessing ids on the interface hiqdev\php\billing\target\TargetInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public static function takeTypes(TargetInterface $other)
    {
        return $other instanceof static ? $other->types : [$other->getType()];

Accessing types on the interface hiqdev\php\billing\target\TargetInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function jsonSerialize()
    {
        return get_object_vars($this);
    }
}