hiqdev\php\billing\target\AbstractTarget

Complexity

Total Complexity

12

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

87.5%

Importance

Changes	1
Bugs	1	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getUniqueId()	0	4	1
A	getId()	0	4	1
A	getType()	0	4	1
A	equals()	0	4	1
A	matches()	0	4	2
A	checkMatches()	0	15	4
A	jsonSerialize()	0	4	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\target;

/**
 * @see TargetInterface
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
abstract class AbstractTarget implements TargetInterface
{
    /**
     * @var int|string
     */
    protected $id;

    /**
     * @var string
     */
    protected $type;

    public function __construct($id, $type)
    {
        $this->id = $id;
        $this->type = $type;
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @return string
     */
    public function getUniqueId()
    {
        return $this->type . ':' . $this->id;
    }

    /**
     * @return bool
     */
    public function equals(TargetInterface $other): bool
    {
        return $this->getUniqueId() === $other->getUniqueId();
    }

    /**
     * @return bool
     */
    public function matches(TargetInterface $other): bool
    {
        return $this->checkMatches($other) || $other->checkMatches($this);
    }

    public function checkMatches(TargetInterface $other): bool
    {
        if ($this->id === null) {
            if ($this->type === null) {
                return true;
            }
            return (string) $this->type === (string) $other->getType();
        }

        if ($this->type === null) {
            return (string) $this->id === (string) $other->id;

Accessing id on the interface hiqdev\php\billing\target\TargetInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        return $this->equals($other);
    }

    public function jsonSerialize()
    {
        return get_object_vars($this);
    }
}