Completed
Push — master ( f79ff7...908aca )
by Dmitry
15:25 queued 10:35
created

src/charge/modifiers/addons/WithTerm.php (2 issues)

Labels
Severity
1
<?php
2
/**
3
 * PHP Billing Library
4
 *
5
 * @link      https://github.com/hiqdev/php-billing
6
 * @package   php-billing
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hiqdev\php\billing\charge\modifiers\addons;
12
13
/**
14
 * With Term trait.
15
 *
16
 * @author Andrii Vasyliev <[email protected]>
17
 */
18
trait WithTerm
19
{
20 6
    public function lasts($term): self
21
    {
22 6
        return $this->addAddon('term', Period::fromString($term));
0 ignored issues
show
It seems like addAddon() must be provided by classes using this trait. How about adding it as abstract method to this trait? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

22
        return $this->/** @scrutinizer ignore-call */ addAddon('term', Period::fromString($term));
Loading history...
23
    }
24
25 8
    public function getTerm(): ?Period
26
    {
27 8
        return $this->getAddon('term');
0 ignored issues
show
It seems like getAddon() must be provided by classes using this trait. How about adding it as abstract method to this trait? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

27
        return $this->/** @scrutinizer ignore-call */ getAddon('term');
Loading history...
28
    }
29
}
30