hiqdev\php\billing\SinglePrice

Complexity

Total Complexity

4

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	calculateUsage()	0	6	2
A	calculatePrice()	0	4	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing;

use hiqdev\php\units\Quantity;
use hiqdev\php\units\QuantityInterface;
use Money\Money;

/**
 * Single Price.
 *
 * - no charge for quantity less then prepaid
 * - same price for any quantity above prepaid
 *
 * @see PriceInterface
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class SinglePrice extends AbstractPrice
{
    /**
     * @var Quantity prepaid quantity also implies Unit
     */
    protected $prepaid;

    /**
     * @var Money
     */
    protected $price;

    public function __construct(
                            $id,
        TargetInterface     $target,
        TypeInterface       $type,
        QuantityInterface   $prepaid,
        Money               $price
    ) {
        parent::__construct($id, $target, $type);
        $this->prepaid  = $prepaid;

$prepaid is of type object<hiqdev\php\units\QuantityInterface>, but the property $prepaid was declared to be of type object<hiqdev\php\units\Quantity>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->price    = $price;
    }

/*

56% of this comment could be valid code. Did you maybe forget this after debugging?

    protected $properties = [
        'id'        => '',
        'target'    => [AbstractTarget::class, 'create'],
        'type'      => [Type::class, 'create'],
        'prepaid'   => [Quantity::class, 'create'],
        'price'     => [MoneyFactory::class, 'create'],
    ];
*/

    /**
     * {@inheritdoc}
     */
    public function calculateUsage(QuantityInterface $quantity)
    {
        $usage = $quantity->convert($this->prepaid->getUnit())->subtract($this->prepaid);

        return $usage->isPositive() ? $usage : null;
    }

    /**
     * {@inheritdoc}
     * Same price for any usage.
     */
    public function calculatePrice(QuantityInterface $usage)
    {
        return $this->price;
    }
}