hiqdev\php\billing\SimpleAction

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	getType()	0	4	1
A	isApplicable()	0	5	2

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing;

use DateTime;
use hiqdev\php\units\QuantityInterface;

/**
 * Simple Action.
 * Charges only same target and same type.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class SimpleAction extends AbstractAction
{
    /**
     * @param mixed $id

There is no parameter named $id. Was it maybe removed?

     * @param CustomerInterface $customer
     * @param TargetInterface $target
     * @param QuantityInterface $quantity
     * @param DateTime $time
     * @param TypeInterface $type
     */
    public function __construct(
        CustomerInterface $customer,
        TargetInterface $target,
        QuantityInterface $quantity,
        DateTime $time,
        TypeInterface $type
    ) {
        parent::__construct($customer, $target, $quantity, $time);
        $this->type = $type;

The property type does not exist. Did you maybe forget to declare it?

    }

    public function getType()
    {
        return $this->type;
    }

    /**
     * {@inheritdoc}
     */
    public function isApplicable(PriceInterface $price)
    {
        return $this->target->equals($price->getTarget()) &&
            $this->getType()->equals($price->getType());
    }
}