Discount::ensureValidValue() - Code Metrics - Inspection of "csfixed" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7d972a...3baf5c )

by Andrii

created 2018-05-18 16:33 UTC

Discount::ensureValidValue() C

↳ Parent: Discount

Complexity

Conditions	7
Paths	5

Size

Total Lines	23
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	7.7656

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	9
cts	12
cp	0.75
rs	6.7272
c	0
b	0
f	0
cc	7
eloc	12
nc	5
nop	1
crap	7.7656

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\charge\modifiers\addons;

use hiqdev\php\billing\charge\modifiers\AddonInterface;
use Money\Currencies\ISOCurrencies;
use Money\Currency;
use Money\Money;
use Money\Parser\DecimalMoneyParser;

/**
 * Discount addon.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class Discount implements AddonInterface
{
    protected static $name = 'discount';

    /**
     * @var string|Money
     */
    protected $value;

    protected $moneyParser;

    public function __construct($value)
    {
        $this->moneyParser = new DecimalMoneyParser(new ISOCurrencies());
        $this->value = $this->ensureValidValue($value);
    }

    public function getValue()
    {
        return $this->value;
    }

    public function isAbsolute()
    {
        return $this->value instanceof Money;
    }

    public function ensureValidValue($value)
    {
        if ($value instanceof Money) {
            return $value;
        }

        if (is_numeric($value)) {
            return (string) $value;
        }

        if (is_string($value) && preg_match('/^(\d{1,5}(\.\d+)?)%$/', $value, $ms)) {
            return $ms[1];
        }

        if (is_string($value) && preg_match('/^(\d{1,5}(\.\d+)?) ([A-Z]{3})$/', $value, $ms)) {
            return $this->moneyParser->parse($ms[1], new Currency($ms[3]));
        }

        /// TODO: add special exception
        var_dump($value);

        $name = static::$name;
        throw new \Exception("invalid $name value: $value");
    }
}


1		<?php
2		/**
3		* PHP Billing Library
4		*
5		* @link https://github.com/hiqdev/php-billing
6		* @package php-billing
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\php\billing\charge\modifiers\addons;
12
13		use hiqdev\php\billing\charge\modifiers\AddonInterface;
14		use Money\Currencies\ISOCurrencies;
15		use Money\Currency;
16		use Money\Money;
17		use Money\Parser\DecimalMoneyParser;
18
19		/**
20		* Discount addon.
21		*
22		* @author Andrii Vasyliev <[email protected]>
23		*/
24		class Discount implements AddonInterface
25		{
26		protected static $name = 'discount';
27
28		/**
29		* @var string\|Money
30		*/
31		protected $value;
32
33		protected $moneyParser;
34
35	11	public function __construct($value)
36		{
37	11	$this->moneyParser = new DecimalMoneyParser(new ISOCurrencies());
38	11	$this->value = $this->ensureValidValue($value);
39	11	}
40
41	9	public function getValue()
42		{
43	9	return $this->value;
44		}
45
46	9	public function isAbsolute()
47		{
48	9	return $this->value instanceof Money;
49		}
50
51	11	public function ensureValidValue($value)
52		{
53	11	if ($value instanceof Money) {
54	4	return $value;
55		}
56
57	9	if (is_numeric($value)) {
58	6	return (string) $value;
59		}
60
61	5	if (is_string($value) && preg_match('/^(\d{1,5}(\.\d+)?)%$/', $value, $ms)) {
62	3	return $ms[1];
63		}
64
65	2	if (is_string($value) && preg_match('/^(\d{1,5}(\.\d+)?) ([A-Z]{3})$/', $value, $ms)) {
66	2	return $this->moneyParser->parse($ms[1], new Currency($ms[3]));
67		}
68
69		/// TODO: add special exception
70		var_dump($value);
		0 ignored issues – show Security Debugging Code introduced 2018-05-18 16:35 UTC by Report Bug Copy Issue Report `var_dump($value);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
71		$name = static::$name;
72		throw new \Exception("invalid $name value: $value");
73		}
74		}
75

hiqdev / php-billing

Push — master ( 7d972a...3baf5c )

Discount::ensureValidValue() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like