hiqdev\php\billing\tests\unit\charge\modifiers\FixedDiscountTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	72
Duplicated Lines	18.06 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

9 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	buildDiscount()	0	4	1
A	testCreateAbsolute()	0	9	1
A	assertAbsolute()	0	6	1
A	testCreateRelative()	0	7	1
A	assertRelative()	0	6	1
A	testAbsoluteModifyCharge()	0	5	1
A	testRelativeModifyCharge()	0	5	1
A	assertCharges()	13	13	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\tests\unit\charge\modifiers;

use hiqdev\php\billing\charge\Charge;
use hiqdev\php\billing\charge\modifiers\FixedDiscount;
use hiqdev\php\billing\tests\unit\action\ActionTest;
use hiqdev\php\units\Quantity;
use Money\Money;

/**
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class FixedDiscountTest extends ActionTest
{
    protected function setUp()
    {
        parent::setUp();
        $this->value = Money::USD(1000);

The property value does not exist. Did you maybe forget to declare it?

        $this->rate = '10';

The property rate does not exist. Did you maybe forget to declare it?

    }

    protected function buildDiscount($value)
    {
        return new FixedDiscount($value);
    }

    public function testCreateAbsolute()
    {
        $abs = $this->buildDiscount($this->value);
        $this->assertAbsolute($this->value, $abs);
        $abs = $this->buildDiscount('10 USD');
        $this->assertAbsolute($this->value, $abs);
        $abs = $this->buildDiscount('10.00 USD');
        $this->assertAbsolute($this->value, $abs);
    }

    public function assertAbsolute($value, $abs)
    {
        $this->assertEquals($value, $abs->getValue());
        $this->assertTrue($abs->isAbsolute());
        $this->assertFalse($abs->isRelative());
    }

    public function testCreateRelative()
    {
        $rel = $this->buildDiscount($this->rate);
        $this->assertRelative($this->rate, $rel);
        $rel = $this->buildDiscount($this->rate . '%');
        $this->assertRelative($this->rate, $rel);
    }

    protected function assertRelative($rate, $rel)
    {
        $this->assertSame($rate, $rel->getValue());
        $this->assertTrue($rel->isRelative());
        $this->assertFalse($rel->isAbsolute());
    }

    public function testAbsoluteModifyCharge()
    {
        $abs = $this->buildDiscount($this->value);
        $this->assertCharges($abs, $this->value);
    }

    public function testRelativeModifyCharge()
    {
        $rel = $this->buildDiscount($this->rate);
        $this->assertCharges($rel, $this->value);
    }

    public function assertCharges($fd, $sum)

This method seems to be duplicated in your project.

    {
        $action = $this->createAction($this->prepaid->multiply(2));

The property prepaid does not exist. Did you maybe forget to declare it?

        $charge = $action->calculateCharge($this->price);
        $charges = $fd->modifyCharge($charge, $action);
        $this->assertInternalType('array', $charges);
        $this->assertSame(2, count($charges));
        $this->assertSame($charge, $charges[0]);
        $discount = $charges[1];
        $this->assertInstanceOf(Charge::class, $discount);
        $this->assertEquals(Quantity::items(1), $discount->getUsage());
        $this->assertEquals($sum, $discount->getSum());
    }
}