AbstractTarget::__construct() - Code Metrics - Inspection of "added SimpleAction with tests" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a7e110...90712e )

by Andrii

created 2017-04-02 11:52 UTC

AbstractTarget::__construct() A

↳ Parent: AbstractTarget

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	2
crap	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing;

/**
 * @see TargetInterface
 *
 * @author Andrii Vasyliev <[email protected]>
 */
abstract class AbstractTarget implements TargetInterface
{
    public function __construct($type, $id)
    {
        $this->id = $id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->type = $type;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->uniqId = $type . ':' . $id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @return string
     */
    public function getUniqId()
    {
        return $this->uniqId;
    }

    /**
     * @return bool
     */
    public function equals(TargetInterface $other)
    {
        return $this->uniqId === $other->getUniqId();
    }
}


1		<?php
2		/**
3		* PHP Billing Library
4		*
5		* @link https://github.com/hiqdev/php-billing
6		* @package php-billing
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\php\billing;
12
13		/**
14		* @see TargetInterface
15		*
16		* @author Andrii Vasyliev <[email protected]>
17		*/
18		abstract class AbstractTarget implements TargetInterface
19		{
20	3	public function __construct($type, $id)
21		{
22	3	$this->id = $id;
		0 ignored issues – show Bug introduced 2017-04-02 11:54 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23	3	$this->type = $type;
		0 ignored issues – show Bug introduced 2017-04-02 11:54 UTC by Report Bug Copy Issue Report The property `type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24	3	$this->uniqId = $type . ':' . $id;
		0 ignored issues – show Bug introduced 2017-04-02 11:54 UTC by Report Bug Copy Issue Report The property `uniqId` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25	3	}
26
27		/**
28		* @return int
29		*/
30		public function getId()
31		{
32		return $this->id;
33		}
34
35		/**
36		* {@inheritdoc}
37		*/
38		public function getType()
39		{
40		return $this->type;
41		}
42
43		/**
44		* @return string
45		*/
46	2	public function getUniqId()
47		{
48	2	return $this->uniqId;
49		}
50
51		/**
52		* @return bool
53		*/
54	2	public function equals(TargetInterface $other)
55		{
56	2	return $this->uniqId === $other->getUniqId();
57		}
58		}
59

hiqdev / php-billing

Push — master ( a7e110...90712e )

AbstractTarget::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like