AbstractTarget - Code Metrics - Inspection of "finished renaming `Customer` <- client and fixed t..." - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 93750f...2ef50e )

by Andrii

created 2017-05-30 16:24 UTC

AbstractTarget A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

60%

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	2
dl	0
loc	53
ccs	9
cts	15
cp	0.6
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	getId()	4	1
A	getUniqId()	4	1
A	__construct()	6	1
A	getType()	4	1
A	equals()	4	1
A	jsonSerialize()	4	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing;

/**
 * @see TargetInterface
 *
 * @author Andrii Vasyliev <[email protected]>
 */
abstract class AbstractTarget implements TargetInterface
{
    protected $id;

    /**
     * @var TypeInterface
     */
    protected $type;

    public function __construct($id, TypeInterface $type)
    {
        $this->id = $id;
        $this->type = $type;
        $this->uniqId = $type->getName() . ':' . $id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function getType()
    {
        return $this->type;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return string
     */
    public function getUniqId()
    {
        return $this->uniqId;
    }

    /**
     * @return bool
     */
    public function equals(TargetInterface $other)
    {
        return $this->uniqId === $other->getUniqId();
    }

    public function jsonSerialize()
    {
        return get_object_vars($this);
    }
}


1		<?php
2		/**
3		* PHP Billing Library
4		*
5		* @link https://github.com/hiqdev/php-billing
6		* @package php-billing
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\php\billing;
12
13		/**
14		* @see TargetInterface
15		*
16		* @author Andrii Vasyliev <[email protected]>
17		*/
18		abstract class AbstractTarget implements TargetInterface
19		{
20		protected $id;
21
22		/**
23		* @var TypeInterface
24		*/
25		protected $type;
26
27	3	public function __construct($id, TypeInterface $type)
28		{
29	3	$this->id = $id;
30	3	$this->type = $type;
31	3	$this->uniqId = $type->getName() . ':' . $id;
		0 ignored issues – show Bug introduced 2017-05-29 09:46 UTC by Report Bug Copy Issue Report The property `uniqId` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32	3	}
33
34		/**
35		* @return int
36		*/
37		public function getId()
38		{
39		return $this->id;
40		}
41
42		/**
43		* {@inheritdoc}
44		*/
45		public function getType()
46		{
47		return $this->type;
		0 ignored issues – show Bug Best Practice introduced 2017-05-29 09:46 UTC by Report Bug Copy Issue Report The return type of `return $this->type;` (`hiqdev\php\billing\TypeInterface`) is incompatible with the return type declared by the interface `hiqdev\php\billing\TargetInterface::getType` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
48		}
49
50		/**
51		* @return string
52		*/
53	2	public function getUniqId()
54		{
55	2	return $this->uniqId;
56		}
57
58		/**
59		* @return bool
60		*/
61	2	public function equals(TargetInterface $other)
62		{
63	2	return $this->uniqId === $other->getUniqId();
64		}
65
66		public function jsonSerialize()
67		{
68		return get_object_vars($this);
69		}
70		}
71

hiqdev / php-billing

Push — master ( 93750f...2ef50e )

AbstractTarget A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like