SimpleAction - Code Metrics - Inspection of "fixed tests after renaming" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6584d5...14a2bb )

by Andrii

created 2017-06-06 13:19 UTC

SimpleAction A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	0
loc	35
ccs	9
cts	9
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__construct()	10	1
A	getType()	4	1
A	isApplicable()	5	2

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\action;

use DateTime;
use hiqdev\php\billing\customer\CustomerInterface;
use hiqdev\php\billing\price\PriceInterface;
use hiqdev\php\billing\target\TargetInterface;
use hiqdev\php\billing\type\TypeInterface;
use hiqdev\php\units\QuantityInterface;

/**
 * Simple Action.
 * Charges only same target and same type.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class SimpleAction extends AbstractAction
{
    /**
     * @param mixed $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param CustomerInterface $customer
     * @param TargetInterface $target
     * @param QuantityInterface $quantity
     * @param DateTime $time
     * @param TypeInterface $type
     */
    public function __construct(
        CustomerInterface $customer,
        TargetInterface $target,
        QuantityInterface $quantity,
        DateTime $time,
        TypeInterface $type
    ) {
        parent::__construct($customer, $target, $quantity, $time);
        $this->type = $type;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getType()
    {
        return $this->type;
    }

    /**
     * {@inheritdoc}
     */
    public function isApplicable(PriceInterface $price)
    {
        return $this->target->equals($price->getTarget()) &&
            $this->getType()->equals($price->getType());
    }
}


1		<?php
2		/**
3		* PHP Billing Library
4		*
5		* @link https://github.com/hiqdev/php-billing
6		* @package php-billing
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\php\billing\action;
12
13		use DateTime;
14		use hiqdev\php\billing\customer\CustomerInterface;
15		use hiqdev\php\billing\price\PriceInterface;
16		use hiqdev\php\billing\target\TargetInterface;
17		use hiqdev\php\billing\type\TypeInterface;
18		use hiqdev\php\units\QuantityInterface;
19
20		/**
21		* Simple Action.
22		* Charges only same target and same type.
23		*
24		* @author Andrii Vasyliev <[email protected]>
25		*/
26		class SimpleAction extends AbstractAction
27		{
28		/**
29		* @param mixed $id
		0 ignored issues – show Bug introduced 2017-05-29 09:46 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
30		* @param CustomerInterface $customer
31		* @param TargetInterface $target
32		* @param QuantityInterface $quantity
33		* @param DateTime $time
34		* @param TypeInterface $type
35		*/
36	2	public function __construct(
37		CustomerInterface $customer,
38		TargetInterface $target,
39		QuantityInterface $quantity,
40		DateTime $time,
41		TypeInterface $type
42		) {
43	2	parent::__construct($customer, $target, $quantity, $time);
44	2	$this->type = $type;
		0 ignored issues – show Bug introduced 2017-04-02 11:54 UTC by Report Bug Copy Issue Report The property `type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45	2	}
46
47	2	public function getType()
48		{
49	2	return $this->type;
50		}
51
52		/**
53		* {@inheritdoc}
54		*/
55	2	public function isApplicable(PriceInterface $price)
56		{
57	2	return $this->target->equals($price->getTarget()) &&
58	2	$this->getType()->equals($price->getType());
59		}
60		}
61

hiqdev / php-billing

Push — master ( 6584d5...14a2bb )

SimpleAction A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like