View GitHub Repository php-billing

Schedule Inspection
Subscribe
Completed
Push — master ( 4a945d...f56bff )
by Andrii
02:24
created

Calculator::calculateCharges()   A

↳ Parent: Calculator

Complexity

Conditions 3
Paths 3

Size

Total Lines 13
Code Lines 8

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 12

Importance

Changes 0
Metric Value
dl 0
loc 13
ccs 0
cts 12
cp 0
rs 9.4285
c 0
b 0
f 0
cc 3
eloc 8
nc 3
nop 1
crap 12
1 
<?php
2 
/**
3 
 * PHP Billing Library
4 
 *
5 
 * @link      https://github.com/hiqdev/php-billing
6 
 * @package   php-billing
7 
 * @license   BSD-3-Clause
8 
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9 
 */
10 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
namespace hiqdev\php\billing\order;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
use hiqdev\php\billing\plan\PlanRepositoryInterface;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
/**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
 * @author Andrii Vasyliev <[email protected]>

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
 */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
class Calculator implements CalculatorInterface

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
    public $repository;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
    public function __construct(PlanRepositoryInterface $repository)

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
        $this->repository = $repository;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
    public function calculateCharges(OrderInterface $order)

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
        $plans = $this->repository->findByOrder($order);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Documentation
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
$order is of type object<hiqdev\php\billing\order\OrderInterface>, but the function expects a object<hiqdev\php\billing\plan\OrderInterface>.
                                                                                                                                                                                                        

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
It seems like the type of the argument is not accepted by the function/method
which you are calling.


In some cases, in particular if PHP’s automatic type-juggling kicks in this
might be fine. In other cases, however this might be a bug.


We suggest to add an explicit type cast like in the following example:


function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
        $charges = [];

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
        foreach ($order->getActions() as $actionKey => $action) {

            


            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
            if (empty($plans[$actionKey])) {

            


            
                                                        
            
                                    
            
            

                
                    33
                

                                    
                                                    
                
                
                
                throw new FailedFindPlan();

            


            
                                                        
            
                                    
            
            

                
                    34
                

                                    
                                                    
                
                
                
            }

            


            
                                                        
            
                                    
            
            

                
                    35
                

                                    
                                                    
                
                
                
            $charges[$actionKey] = $plans[$actionKey]->calculateCharges($action);

            


            
                                                        
            
                                    
            
            

                
                    36
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    37
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                
        return $charges;

            


            
                                                        
            
                                    
            
            

                
                    39
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    40
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    41