AbstractPrice::calculateSum() - Code Metrics - Inspection of "moved calculateCharge to Action <- Price" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b14db...a7e110 )

by Andrii

created 2017-04-02 09:10 UTC

AbstractPrice::calculateSum() A

↳ Parent: AbstractPrice

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
nc	3
cc	3
eloc	8
nop	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing;

use hiqdev\php\units\QuantityInterface;

/**
 * Price.
 * @see PriceInterface
 *
 * @author Andrii Vasyliev <[email protected]>
 */
abstract class AbstractPrice implements PriceInterface
{
    /**
     * @var integer
     */
    protected $id;

    /**
     * @var Tariff
     */
    protected $tariff;

    /**
     * @var Target
     */
    protected $target;

    /**
     * @var Type
     */
    protected $type;

    public function __construct(TargetInterface $target, TypeInterface $type)
    {
        $this->target = $target;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->type = $type;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * @inheritdoc
     */
    public function getTarget()
    {
        return $this->target;
    }

    /**
     * @inheritdoc
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @inheritdoc
     * Default sum calculation method: sum = price * usage
     */
    public function calculateSum(QuantityInterface $quantity)
    {
        $usage = $this->calculateUsage($quantity);
        if ($usage === null) {
            return null;
        }

        $price = $this->calculatePrice($quantity);
        if ($price === null) {
            return null;
        }

        return $price->multiply($usage->getQuantity());
    }

    /**
     * @inheritdoc
     */
    abstract public function calculateUsage(QuantityInterface $quantity);

    /**
     * @inheritdoc
     */
    abstract public function calculatePrice(QuantityInterface $action);
}


1			<?php
2			/**
3			* PHP Billing Library
4			*
5			* @link https://github.com/hiqdev/php-billing
6			* @package php-billing
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\billing;
12
13			use hiqdev\php\units\QuantityInterface;
14
15			/**
16			* Price.
17			* @see PriceInterface
18			*
19			* @author Andrii Vasyliev <[email protected]>
20			*/
21			abstract class AbstractPrice implements PriceInterface
22			{
23			/**
24			* @var integer
25			*/
26			protected $id;
27
28			/**
29			* @var Tariff
30			*/
31			protected $tariff;
32
33			/**
34			* @var Target
35			*/
36			protected $target;
37
38			/**
39			* @var Type
40			*/
41			protected $type;
42
43			public function __construct(TargetInterface $target, TypeInterface $type)
44			{
45			$this->target = $target;
			0 ignored issues – show Documentation Bug introduced 2017-04-01 18:18 UTC by Report Bug Copy Issue Report `$target` is of type `object<hiqdev\php\billing\TargetInterface>`, but the property `$target` was declared to be of type `object<hiqdev\php\billing\Target>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
46			$this->type = $type;
			0 ignored issues – show Documentation Bug introduced 2017-04-01 18:18 UTC by Report Bug Copy Issue Report `$type` is of type `object<hiqdev\php\billing\TypeInterface>`, but the property `$type` was declared to be of type `object<hiqdev\php\billing\Type>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
47			}
48
49			/**
50			* @inheritdoc
51			*/
52			public function getTarget()
53			{
54			return $this->target;
55			}
56
57			/**
58			* @inheritdoc
59			*/
60			public function getType()
61			{
62			return $this->type;
63			}
64
65			/**
66			* @inheritdoc
67			* Default sum calculation method: sum = price * usage
68			*/
69			public function calculateSum(QuantityInterface $quantity)
70			{
71			$usage = $this->calculateUsage($quantity);
72			if ($usage === null) {
73			return null;
74			}
75
76			$price = $this->calculatePrice($quantity);
77			if ($price === null) {
78			return null;
79			}
80
81			return $price->multiply($usage->getQuantity());
82			}
83
84			/**
85			* @inheritdoc
86			*/
87			abstract public function calculateUsage(QuantityInterface $quantity);
88
89			/**
90			* @inheritdoc
91			*/
92			abstract public function calculatePrice(QuantityInterface $action);
93			}
94

hiqdev / php-billing

Push — master ( 6b14db...a7e110 )

AbstractPrice::calculateSum() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like