hiqdev\php\billing\type\Type

Complexity

Total Complexity

14

Size/Duplication

Total Lines	72
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

84%

Importance

Changes	3
Bugs	1	Features	2

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getName()	0	4	1
A	getId()	0	4	1
A	getUniqueId()	0	4	2
A	equals()	0	5	2
A	matches()	0	6	3
A	checkMatches()	8	8	3
A	jsonSerialize()	0	7	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\type;

/**
 * General Type.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class Type implements TypeInterface
{
    /**
     * @var int|string
     */
    protected $id;

    /**
     * @var string
     */
    protected $name;

    public function __construct($id, $name = null)
    {
        $this->id = $id;
        $this->name = $name;
    }

    /**
     * {@inheritdoc}
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return $this->name;
    }

    public function getUniqueId()
    {
        return $this->getId() ?: $this->getName();

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

    }

    /**
     * @return string
     */
    public function equals(TypeInterface $other)
    {
        return $this->id === $other->getId() &&
            $this->name === $other->getName();

Consider using $other->name. There is an issue with getName() and APC-enabled PHP versions.

    }

    public function matches(TypeInterface $other)
    {
        return $this->id === self::ANY || $other->id === self::ANY

Accessing id on the interface hiqdev\php\billing\type\TypeInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            ? $this->checkMatches($this->name, $other->getName())

Consider using $other->name. There is an issue with getName() and APC-enabled PHP versions.

            : $this->checkMatches($this->id, $other->getId());
    }

    protected function checkMatches($lhs, $rhs)

This method seems to be duplicated in your project.

    {
        if ($lhs === self::NONE || $rhs === self::NONE) {
            return false;
        }

        return (string) $lhs === (string) $rhs;
    }

    public function jsonSerialize()
    {
        return array_filter([
            'name' => $this->name,
            'id' => $this->id,
        ]);
    }
}