hiqdev\php\billing\charge\Aggregator

Complexity

Total Complexity

11

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	aggregateCharges()	0	16	4
A	aggregateQuantity()	0	3	1
A	aggregateBills()	0	12	3
A	aggregateSum()	0	3	1
A	aggregateBill()	0	12	1
A	__construct()	0	3	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\charge;

use hiqdev\php\billing\bill\Bill;
use hiqdev\php\billing\bill\BillInterface;
use hiqdev\php\units\QuantityInterface;
use Money\Money;

/**
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class Aggregator implements AggregatorInterface
{
    /**
     * @var BillInterface[]
     */
    protected $bills = [];

    /**
     * @var GeneralizerInterface
     */
    protected $generalizer;

    public function __construct(GeneralizerInterface $generalizer)
    {
        $this->generalizer = $generalizer;
    }

    public function aggregateCharges(array $charges)
    {
        $bills = [];
        foreach ($charges as $charge) {
            if (is_array($charge)) {
                $others = $this->aggregateCharges($charge);
                $bills = $this->aggregateBills($bills, $others);
            } elseif ($charge instanceof ChargeInterface) {
                $bill = $this->generalizer->createBill($charge);
                $bills = $this->aggregateBills($bills, [$bill]);
            } else {
                throw new \Exception('not a Charge given to Aggregator');
            }
        }

        return $bills;

The expression return $bills returns an array which contains values of type hiqdev\php\billing\bill\BillInterface which are incompatible with the return type hiqdev\php\billing\charge\Bill mandated by hiqdev\php\billing\charge\AggregatorInterface::aggregateCharges().

    }

    /**
     * Aggregate arrays of bills.
     * @param BillInterface[] $bills
     * @param BillInterface[] $others
     * @return BillInterface[]
     */
    public function aggregateBills(array $bills, array $others)
    {
        foreach ($others as $bill) {
            $uid = $bill->getUniqueString();

The method getUniqueString() does not exist on hiqdev\php\billing\bill\BillInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to hiqdev\php\billing\bill\BillInterface.

            if (empty($bills[$uid])) {
                $bills[$uid] = $bill;
            } else {
                $bills[$uid] = $this->aggregateBill($bills[$uid], $bill);
            }
        }

        return $bills;
    }

    public function aggregateBill(BillInterface $first, BillInterface $other)
    {
        return new Bill(
            null,
            $first->getType(),
            $first->getTime(),

The method getTime() does not exist on hiqdev\php\billing\bill\BillInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to hiqdev\php\billing\bill\BillInterface.

            $this->aggregateSum($first->getSum(), $other->getSum()),
            $this->aggregateQuantity($first->getQuantity(), $other->getQuantity()),
            $first->getCustomer(),
            $first->getTarget(),
            $first->getPlan(),
            array_merge($first->getCharges(), $other->getCharges())
        );
    }

    public function aggregateSum(Money $first, Money $other)
    {
        return $first->add($other);
    }

    public function aggregateQuantity(QuantityInterface $first, QuantityInterface $other)
    {
        return $first->add($other);
    }
}