SinglePrice::calculateUsage() - Code Metrics - Inspection of "moved to entity dirs" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 866870...6584d5 )

by Andrii

created 2017-06-06 09:58 UTC

SinglePrice::calculateUsage() A

↳ Parent: SinglePrice

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
ccs	0
cts	5
cp	0
rs	9.4285
cc	2
eloc	3
nc	2
nop	1
crap	6

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\price;

use hiqdev\php\billing\target\TargetInterface;
use hiqdev\php\billing\type\TypeInterface;
use hiqdev\php\units\Quantity;
use hiqdev\php\units\QuantityInterface;
use Money\Money;

/**
 * Single Price.
 *
 * - no charge for quantity less then prepaid
 * - same price for any quantity above prepaid
 *
 * @see PriceInterface
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class SinglePrice extends AbstractPrice
{
    /**
     * @var Quantity prepaid quantity also implies Unit
     */
    protected $prepaid;

    /**
     * @var Money
     */
    protected $price;

    public function __construct(
                            $id,
        TargetInterface     $target,
        TypeInterface       $type,
        QuantityInterface   $prepaid,
        Money               $price
    ) {
        parent::__construct($id, $target, $type);
        $this->prepaid  = $prepaid;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->price    = $price;
    }

/*

    protected $properties = [
        'id'        => '',
        'target'    => [AbstractTarget::class, 'create'],
        'type'      => [Type::class, 'create'],
        'prepaid'   => [Quantity::class, 'create'],
        'price'     => [MoneyFactory::class, 'create'],
    ];
*/

    /**
     * {@inheritdoc}
     */
    public function calculateUsage(QuantityInterface $quantity)
    {
        $usage = $quantity->convert($this->prepaid->getUnit())->subtract($this->prepaid);

        return $usage->isPositive() ? $usage : null;
    }

    /**
     * {@inheritdoc}
     * Same price for any usage.
     */
    public function calculatePrice(QuantityInterface $usage)
    {
        return $this->price;
    }
}


1			<?php
2			/**
3			* PHP Billing Library
4			*
5			* @link https://github.com/hiqdev/php-billing
6			* @package php-billing
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\billing\price;
12
13			use hiqdev\php\billing\target\TargetInterface;
14			use hiqdev\php\billing\type\TypeInterface;
15			use hiqdev\php\units\Quantity;
16			use hiqdev\php\units\QuantityInterface;
17			use Money\Money;
18
19			/**
20			* Single Price.
21			*
22			* - no charge for quantity less then prepaid
23			* - same price for any quantity above prepaid
24			*
25			* @see PriceInterface
26			*
27			* @author Andrii Vasyliev <[email protected]>
28			*/
29			class SinglePrice extends AbstractPrice
30			{
31			/**
32			* @var Quantity prepaid quantity also implies Unit
33			*/
34			protected $prepaid;
35
36			/**
37			* @var Money
38			*/
39			protected $price;
40
41			public function __construct(
42			$id,
43			TargetInterface $target,
44			TypeInterface $type,
45			QuantityInterface $prepaid,
46			Money $price
47			) {
48			parent::__construct($id, $target, $type);
49			$this->prepaid = $prepaid;
			0 ignored issues – show Documentation Bug introduced 2017-06-01 12:32 UTC by Report Bug Copy Issue Report `$prepaid` is of type `object<hiqdev\php\units\QuantityInterface>`, but the property `$prepaid` was declared to be of type `object<hiqdev\php\units\Quantity>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
50			$this->price = $price;
51			}
52
53			/*
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-29 09:46 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
54			protected $properties = [
55			'id' => '',
56			'target' => [AbstractTarget::class, 'create'],
57			'type' => [Type::class, 'create'],
58			'prepaid' => [Quantity::class, 'create'],
59			'price' => [MoneyFactory::class, 'create'],
60			];
61			*/
62
63			/**
64			* {@inheritdoc}
65			*/
66			public function calculateUsage(QuantityInterface $quantity)
67			{
68			$usage = $quantity->convert($this->prepaid->getUnit())->subtract($this->prepaid);
69
70			return $usage->isPositive() ? $usage : null;
71			}
72
73			/**
74			* {@inheritdoc}
75			* Same price for any usage.
76			*/
77			public function calculatePrice(QuantityInterface $usage)
78			{
79			return $this->price;
80			}
81			}
82

hiqdev / php-billing

Push — master ( 866870...6584d5 )

SinglePrice::calculateUsage() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like