Bill::__construct() - Code Metrics - Inspection of "moved to entity dirs" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 866870...6584d5 )

by Andrii

created 2017-06-06 09:58 UTC

Bill::__construct() A

↳ Parent: Bill

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	19
ccs	0
cts	19
cp	0
rs	9.4285
cc	1
eloc	17
nc	1
nop	8
crap	2

How to fix Many Parameters

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\bill;

use DateTime;
use hiqdev\php\billing\EntityInterface;
use hiqdev\php\billing\customer\Customer;
use hiqdev\php\billing\target\Target;
use hiqdev\php\billing\type\Type;
use hiqdev\php\units\Quantity;
use Money\Money;

/**
 * Bill.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class Bill implements EntityInterface
{
    /**
     * @var integer
     */
    protected $id;

    /**
     * @var Type
     */
    protected $type;

    /**
     * @var DateTime
     */
    protected $time;

    /**
     * @var Money
     */
    protected $sum;

    /**
     * @var Quantity
     */
    protected $quantity;

    /**
     * @var Customer
     */
    protected $customer;

    /**
     * @var Target
     */
    protected $target;

    /**
     * @var Plan
     */
    protected $plan;

    /**
     * @var bool
     */
    protected $isFinished;

    /**
     * @var Charge[]
     */
    protected $charges = [];

    public function __construct(
                    $id,
        Type        $type,
        DateTime    $time,
        Money       $sum,
        Quantity    $quantity,
        Customer    $customer = null,
        Target      $target = null,
        Plan        $plan = null
    ) {
        $this->id       = $id;
        $this->type     = $type;
        $this->time     = $time;
        $this->sum      = $sum;
        $this->quantity = $quantity;
        $this->customer = $customer;
        $this->target   = $target;
        $this->plan     = $plan;
    }

    public function jsonSerialize()
    {
        return get_object_vars($this);
    }
}


1			<?php
2			/**
3			* PHP Billing Library
4			*
5			* @link https://github.com/hiqdev/php-billing
6			* @package php-billing
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\billing\bill;
12
13			use DateTime;
14			use hiqdev\php\billing\EntityInterface;
15			use hiqdev\php\billing\customer\Customer;
16			use hiqdev\php\billing\target\Target;
17			use hiqdev\php\billing\type\Type;
18			use hiqdev\php\units\Quantity;
19			use Money\Money;
20
21			/**
22			* Bill.
23			*
24			* @author Andrii Vasyliev <[email protected]>
25			*/
26			class Bill implements EntityInterface
27			{
28			/**
29			* @var integer
30			*/
31			protected $id;
32
33			/**
34			* @var Type
35			*/
36			protected $type;
37
38			/**
39			* @var DateTime
40			*/
41			protected $time;
42
43			/**
44			* @var Money
45			*/
46			protected $sum;
47
48			/**
49			* @var Quantity
50			*/
51			protected $quantity;
52
53			/**
54			* @var Customer
55			*/
56			protected $customer;
57
58			/**
59			* @var Target
60			*/
61			protected $target;
62
63			/**
64			* @var Plan
65			*/
66			protected $plan;
67
68			/**
69			* @var bool
70			*/
71			protected $isFinished;
72
73			/**
74			* @var Charge[]
75			*/
76			protected $charges = [];
77
78			public function __construct(
79			$id,
80			Type $type,
81			DateTime $time,
82			Money $sum,
83			Quantity $quantity,
84			Customer $customer = null,
85			Target $target = null,
86			Plan $plan = null
87			) {
88			$this->id = $id;
89			$this->type = $type;
90			$this->time = $time;
91			$this->sum = $sum;
92			$this->quantity = $quantity;
93			$this->customer = $customer;
94			$this->target = $target;
95			$this->plan = $plan;
96			}
97
98			public function jsonSerialize()
99			{
100			return get_object_vars($this);
101			}
102			}
103

hiqdev / php-billing

Push — master ( 866870...6584d5 )

Bill::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like