Type::matches() - Code Metrics - Inspection of "added tests for `Type::matches()`" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 791681...fd1dbe )

by Andrii

created 2018-01-02 15:50 UTC

Type::matches() A

↳ Parent: Type

Complexity

Conditions	3
Paths	4

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	4
nc	4
nop	1
crap	3

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\type;

/**
 * General Type.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class Type implements TypeInterface
{
    /**
     * @var int|string
     */
    protected $id;

    /**
     * @var string
     */
    protected $name;

    public function __construct($id, $name = null)
    {
        $this->id = $id;
        $this->name = $name;
    }

    /**
     * {@inheritdoc}
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return $this->name;
    }

    public function getUniqueId()
    {
        return $this->getId() ?: $this->getName();

    }

    /**
     * @return string
     */
    public function equals(TypeInterface $other)
    {
        return $this->id === $other->getId() &&
            $this->name === $other->getName();

    }

    public function matches(TypeInterface $other)
    {
        return $this->id === null || $other->id === null
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ? (string) $this->name === (string) $other->name
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            : (string) $this->id === (string) $other->id;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function jsonSerialize()
    {
        return array_filter([
            'name' => $this->name,
            'id' => $this->id,
        ]);
    }
}


1		<?php
2		/**
3		* PHP Billing Library
4		*
5		* @link https://github.com/hiqdev/php-billing
6		* @package php-billing
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\php\billing\type;
12
13		/**
14		* General Type.
15		*
16		* @author Andrii Vasyliev <[email protected]>
17		*/
18		class Type implements TypeInterface
19		{
20		/**
21		* @var int\|string
22		*/
23		protected $id;
24
25		/**
26		* @var string
27		*/
28		protected $name;
29
30	10	public function __construct($id, $name = null)
31		{
32	10	$this->id = $id;
33	10	$this->name = $name;
34	10	}
35
36		/**
37		* {@inheritdoc}
38		*/
39	4	public function getId()
40		{
41	4	return $this->id;
42		}
43
44		/**
45		* {@inheritdoc}
46		*/
47	8	public function getName()
48		{
49	8	return $this->name;
50		}
51
52	2	public function getUniqueId()
53		{
54	2	return $this->getId() ?: $this->getName();
		0 ignored issues – show Bug introduced 2017-12-20 16:13 UTC by Report Bug Copy Issue Report Consider using `$this->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
55		}
56
57		/**
58		* @return string
59		*/
60	2	public function equals(TypeInterface $other)
61		{
62	2	return $this->id === $other->getId() &&
63	2	$this->name === $other->getName();
		0 ignored issues – show Bug introduced 2018-01-02 15:52 UTC by Report Bug Copy Issue Report Consider using `$other->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
64		}
65
66	6	public function matches(TypeInterface $other)
67		{
68	6	return $this->id === null \|\| $other->id === null
		0 ignored issues – show Bug introduced 2017-09-10 14:07 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `hiqdev\php\billing\type\TypeInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
69	3	? (string) $this->name === (string) $other->name
		0 ignored issues – show Bug introduced 2017-09-10 14:07 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `hiqdev\php\billing\type\TypeInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
70	6	: (string) $this->id === (string) $other->id;
		0 ignored issues – show Bug introduced 2017-09-10 14:07 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `hiqdev\php\billing\type\TypeInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
71		}
72
73		public function jsonSerialize()
74		{
75		return array_filter([
76		'name' => $this->name,
77		'id' => $this->id,
78		]);
79		}
80		}
81

hiqdev / php-billing

Push — master ( 791681...fd1dbe )

Type::matches() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like