SimpleCalculator::__construct() - Code Metrics - Inspection of "Added `SimpleCalculator`" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a88c1a...2a7402 )

by Andrii

created 2020-04-14 14:43 UTC

SimpleCalculator::__construct() A

↳ Parent: SimpleCalculator

Complexity

Conditions	5
Paths	6

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	8
c	1
b	0
f	0
nc	6
nop	3
dl	0
loc	14
rs	9.6111

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\tests\support\order;

use hiqdev\php\billing\charge\Generalizer;
use hiqdev\php\billing\charge\GeneralizerInterface;
use hiqdev\php\billing\order\Calculator;
use hiqdev\php\billing\plan\PlanInterface;
use hiqdev\php\billing\sale\SaleInterface;
use hiqdev\php\billing\tests\support\plan\SimplePlanRepository;
use hiqdev\php\billing\tests\support\sale\SimpleSaleRepository;

class SimpleCalculator extends Calculator
{
    /**
     * @param GeneralizerInterface $generalizer
     * @param SaleRepositoryInterface|SaleInterface $sale
filter:
    dependency_paths: ["lib/*"]
     * @param PlanRepositoryInterface|PlanInterface $plan
filter:
    dependency_paths: ["lib/*"]
     */
    public function __construct(GeneralizerInterface $generalizer = null, $sale = null, $plan = null)
    {
        $this->generalizer = $generalizer ?: new Generalizer();
        if ($sale instanceof SaleInterface) {
            if (empty($plan)) {
                $plan = $sale->getPlan();
            }
            $sale = new SimpleSaleRepository($sale);
        }
        if ($plan instanceof PlanInterface) {
            $plan = new SimplePlanRepository($plan);
        }

        return parent::__construct($this->generalizer, $sale, $plan);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function getGeneralizer(): GeneralizerInterface
    {
        return $this->generalizer;
    }
}


1			<?php
2			/**
3			* PHP Billing Library
4			*
5			* @link https://github.com/hiqdev/php-billing
6			* @package php-billing
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\billing\tests\support\order;
12
13			use hiqdev\php\billing\charge\Generalizer;
14			use hiqdev\php\billing\charge\GeneralizerInterface;
15			use hiqdev\php\billing\order\Calculator;
16			use hiqdev\php\billing\plan\PlanInterface;
17			use hiqdev\php\billing\sale\SaleInterface;
18			use hiqdev\php\billing\tests\support\plan\SimplePlanRepository;
19			use hiqdev\php\billing\tests\support\sale\SimpleSaleRepository;
20
21			class SimpleCalculator extends Calculator
22			{
23			/**
24			* @param GeneralizerInterface $generalizer
25			* @param SaleRepositoryInterface\|SaleInterface $sale
			0 ignored issues – show Bug introduced 2020-04-14 14:46 UTC by Report Bug Copy Issue Report The type `hiqdev\php\billing\tests...SaleRepositoryInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
26			* @param PlanRepositoryInterface\|PlanInterface $plan
			0 ignored issues – show Bug introduced 2020-04-14 14:46 UTC by Report Bug Copy Issue Report The type `hiqdev\php\billing\tests...PlanRepositoryInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
27			*/
28			public function __construct(GeneralizerInterface $generalizer = null, $sale = null, $plan = null)
29			{
30			$this->generalizer = $generalizer ?: new Generalizer();
31			if ($sale instanceof SaleInterface) {
32			if (empty($plan)) {
33			$plan = $sale->getPlan();
34			}
35			$sale = new SimpleSaleRepository($sale);
36			}
37			if ($plan instanceof PlanInterface) {
38			$plan = new SimplePlanRepository($plan);
39			}
40
41			return parent::__construct($this->generalizer, $sale, $plan);
			0 ignored issues – show Bug introduced 2020-04-14 14:46 UTC by Report Bug Copy Issue Report Are you sure the usage of `parent::__construct($thi...eralizer, $sale, $plan)` targeting `hiqdev\php\billing\order\Calculator::__construct()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
42			}
43
44			public function getGeneralizer(): GeneralizerInterface
45			{
46			return $this->generalizer;
47			}
48			}
49

hiqdev / php-billing

Push — master ( a88c1a...2a7402 )

SimpleCalculator::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like