hiqdev\php\billing\target\AbstractTarget

Complexity

Total Complexity

20

Size/Duplication

Total Lines	103
Duplicated Lines	7.77 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

91.18%

Importance

Changes	1
Bugs	1	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getId()	0	4	1
A	getType()	0	4	1
A	getUniqueId()	0	7	3
A	equals()	0	4	1
A	matches()	0	4	2
B	checkMatches()	0	16	5
A	matchIds()	0	4	1
A	matchTypes()	0	4	1
A	matchStrings()	8	8	3
A	jsonSerialize()	0	4	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\target;

/**
 * @see TargetInterface
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
abstract class AbstractTarget implements TargetInterface
{
    /**
     * @var int|string
     */
    protected $id;

    /**
     * @var string
     */
    protected $type;

    public function __construct($id, $type)
    {
        $this->id = $id;
        $this->type = $type;
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @return string
     */
    public function getUniqueId()
    {
        $id = $this->getId();
        $type = $this->getType();

        return ($type === self::ANY ? '' : $type) . ':' . ($id === self::ANY ? '' : $id);

The strict comparison === seems to always evaluate to false as the types of $type (string) and self::ANY (integer) can never be identical. Maybe you want to use a loose comparison == instead?

    }

    /**
     * @return bool
     */
    public function equals(TargetInterface $other): bool
    {
        return $this->getUniqueId() === $other->getUniqueId();
    }

    /**
     * @return bool
     */
    public function matches(TargetInterface $other): bool
    {
        return $this->checkMatches($other) || $other->checkMatches($this);
    }

    public function checkMatches(TargetInterface $other): bool
    {
        if ($this->id === self::ANY) {
            if ($this->type === self::ANY) {

The strict comparison === seems to always evaluate to false as the types of $this->type (string) and self::ANY (integer) can never be identical. Maybe you want to use a loose comparison == instead?

                return true;
            }

            return $this->matchTypes($other);
        }

        if ($this->type === self::ANY) {

The strict comparison === seems to always evaluate to false as the types of $this->type (string) and self::ANY (integer) can never be identical. Maybe you want to use a loose comparison == instead?

            return $this->matchIds($other);
        }

        return $this->matchIds($other) && $this->matchTypes($other);
    }

    protected function matchIds(TargetInterface $other)
    {
        return $this->matchStrings($this->id, $other->getId());
    }

    protected function matchTypes(TargetInterface $other)
    {
        return $this->matchStrings($this->type, $other->getType());
    }

    protected function matchStrings($lhs, $rhs)

This method seems to be duplicated in your project.

    {
        if ($lhs === self::NONE || $rhs === self::NONE) {
            return false;
        }

        return (string) $lhs === (string) $rhs;
    }


    public function jsonSerialize()
    {
        return get_object_vars($this);
    }
}