Sale::__construct() - Code Metrics - Inspection of "fixed tests with SimpleSaleRepository" - hiqdev/php-billing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8530e7...2147ca )

by Andrii

created 2018-01-22 12:10 UTC

Sale::__construct() A

↳ Parent: Sale

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	11
nc	1
nop	5
crap	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\sale;

use DateTimeImmutable;
use hiqdev\php\billing\customer\CustomerInterface;
use hiqdev\php\billing\plan\PlanInterface;
use hiqdev\php\billing\target\TargetInterface;

/**
 * Sale.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class Sale implements SaleInterface
{
    /**
     * @var int
     */
    protected $id;

    /**
     * @var TargetInterface
     */
    protected $target;

    /**
     * @var CustomerInterface
     */
    protected $customer;

    /**
     * @var PlanInterface
     */
    protected $plan;

    /**
     * @var DateTimeImmutable
     */
    protected $time;

    public function __construct(
                            $id,
        TargetInterface     $target,
        CustomerInterface   $customer,
        PlanInterface       $plan,
        DateTimeImmutable   $time = null
    ) {
        $this->id = $id;
        $this->target = $target;
        $this->customer = $customer;
        $this->plan = $plan;
        $this->time = $time;
    }

    public function getId()
    {
        return $this->id;
    }

    public function getTarget()
    {
        return $this->target;
    }

    public function getCustomer()
    {
        return $this->customer;
    }

    public function getPlan()
    {
        return $this->plan;
    }

    public function getTime()
    {
        return $this->time;
    }

    public function setId($id)

    {
        if ($this->id === $id) {
            return;
        }
        if ($this->id !== null) {
            throw new \Exception('cannot reassign sale id');
        }
        $this->id = $id;
    }
}


1			<?php
2			/**
3			* PHP Billing Library
4			*
5			* @link https://github.com/hiqdev/php-billing
6			* @package php-billing
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\billing\sale;
12
13			use DateTimeImmutable;
14			use hiqdev\php\billing\customer\CustomerInterface;
15			use hiqdev\php\billing\plan\PlanInterface;
16			use hiqdev\php\billing\target\TargetInterface;
17
18			/**
19			* Sale.
20			*
21			* @author Andrii Vasyliev <[email protected]>
22			*/
23			class Sale implements SaleInterface
24			{
25			/**
26			* @var int
27			*/
28			protected $id;
29
30			/**
31			* @var TargetInterface
32			*/
33			protected $target;
34
35			/**
36			* @var CustomerInterface
37			*/
38			protected $customer;
39
40			/**
41			* @var PlanInterface
42			*/
43			protected $plan;
44
45			/**
46			* @var DateTimeImmutable
47			*/
48			protected $time;
49
50	3		public function __construct(
51			$id,
52			TargetInterface $target,
53			CustomerInterface $customer,
54			PlanInterface $plan,
55			DateTimeImmutable $time = null
56			) {
57	3		$this->id = $id;
58	3		$this->target = $target;
59	3		$this->customer = $customer;
60	3		$this->plan = $plan;
61	3		$this->time = $time;
62	3		}
63
64			public function getId()
65			{
66			return $this->id;
67			}
68
69			public function getTarget()
70			{
71			return $this->target;
72			}
73
74			public function getCustomer()
75			{
76			return $this->customer;
77			}
78
79	2		public function getPlan()
80			{
81	2		return $this->plan;
82			}
83
84			public function getTime()
85			{
86			return $this->time;
87			}
88
89		View Code Duplication	public function setId($id)
			0 ignored issues – show Duplication introduced 2017-11-25 16:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90			{
91			if ($this->id === $id) {
92			return;
93			}
94			if ($this->id !== null) {
95			throw new \Exception('cannot reassign sale id');
96			}
97			$this->id = $id;
98			}
99			}
100

hiqdev / php-billing

Push — master ( 8530e7...2147ca )

Sale::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like