hiqdev\php\billing\tests\unit\sale\SimpleSaleRepository

Complexity

Total Complexity

5

Size/Duplication

Total Lines	29
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	findByAction()	4	4	1
A	findByOrder()	9	9	2
A	findByIds()	4	4	1

<?php
/**
 * PHP Billing Library
 *
 * @link      https://github.com/hiqdev/php-billing
 * @package   php-billing
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\billing\tests\unit\sale;

use hiqdev\php\billing\action\ActionInterface;
use hiqdev\php\billing\order\OrderInterface;
use hiqdev\php\billing\sale\SaleInterface;
use hiqdev\php\billing\sale\SaleRepositoryInterface;

class SimpleSaleRepository implements SaleRepositoryInterface

This class seems to be duplicated in your project.

{
    protected $sale;

    public function __construct(SaleInterface $sale)
    {
        $this->sale = $sale;
    }

    public function findByAction(ActionInterface $action)

The parameter $action is not used and could be removed.

    {
        return $this->sale;
    }

    public function findByOrder(OrderInterface $order)
    {
        $sales = [];
        foreach ($order->getActions() as $actionKey => $action) {
            $sales[$actionKey] = $this->findByAction($action);
        }

        return $sales;
    }

    public function findByIds(array $ids)

The parameter $ids is not used and could be removed.

    {
        throw new \Exception('not implemented');
    }
}