Issues (426)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/controllers/CartController.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Finance module for HiPanel
4
 *
5
 * @link      https://github.com/hiqdev/hipanel-module-finance
6
 * @package   hipanel-module-finance
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hipanel\modules\finance\controllers;
12
13
use hipanel\filters\EasyAccessControl;
14
use hipanel\helpers\Url;
15
use hipanel\modules\client\models\Client;
16
use hipanel\modules\finance\cart\CartFinisher;
17
use hipanel\modules\finance\widgets\CartCurrencyNegotiator;
18
use hipanel\modules\finance\Module;
19
use hiqdev\yii2\merchant\models\DepositForm;
20
use Yii;
21
22
class CartController extends \yii\web\Controller
23
{
24
    /**
25
     * @var Module
26
     */
27
    public $module;
28
29
    public function behaviors()
30
    {
31
        return [
32
            [
33
                'class' => EasyAccessControl::class,
34
                'actions' => [
35
                    'deposit' => '@',
36
                    'select' => '@',
37
                    'partial' => '@',
38
                    'full' => '@',
39
                    'finish' => '@',
40
                ],
41
            ],
42
        ];
43
    }
44
45
    /**
46
     * @param float $amount
47
     * @param string $currency
48
     * @return \yii\web\Response
49
     */
50
    private function renderDeposit(float $amount, string $currency)
51
    {
52
        $cart = $this->module->getCart();
53
54
        $form = new DepositForm([
55
            'amount' => $amount,
56
            'currency' => $currency,
57
            'finishUrl' => $cart->getCurrency() === $currency
58
                ? Url::to(['@finance/cart/finish'])
59
                : Url::to(['@finance/cart/finish', 'exchangeFromCurrency' => $currency])
60
        ]);
61
        $form->validate();
62
63
        return $this->module->getMerchant()->renderDeposit($form);
64
    }
65
66
    public function actionSelect()
67
    {
68
        return $this->render('select', [
69
            'negotiator' => $this->getNegotiator()
70
        ]);
71
    }
72
73
    /** @var \hipanel\modules\finance\widgets\CartCurrencyNegotiator */
74
    private $negotiator;
75
    private function getNegotiator(): CartCurrencyNegotiator
76
    {
77
        if ($this->negotiator === null) {
78
            $this->negotiator = new CartCurrencyNegotiator([
79
                'cart' => $this->module->getCart(),
80
                'client' => $this->getClient(),
81
                'merchantModule' => $this->module->getMerchant(),
82
            ]);
83
        }
84
85
        return $this->negotiator;
86
    }
87
88 View Code Duplication
    public function actionFull(string $currency = null)
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
89
    {
90
        $negotiator = $this->getNegotiator();
91
        $currency = $currency ?? $this->module->getCart()->getCurrency();
92
93
        return $this->renderDeposit($negotiator->getFullAmount($currency), $currency);
94
    }
95
96 View Code Duplication
    public function actionPartial(string $currency = null)
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
97
    {
98
        $negotiator = $this->getNegotiator();
99
        $currency = $currency ?? $this->module->getCart()->getCurrency();
100
101
        return $this->renderDeposit($negotiator->getPartialAmount($currency), $currency);
102
    }
103
104
    public function actionFinish(string $exchangeFromCurrency = null)
105
    {
106
        $cart = $this->module->getCart();
107
108
        $finisher = new CartFinisher([
109
            'cart' => $cart,
110
            'exchangeFromCurrency' => $exchangeFromCurrency
111
        ]);
112
        $finisher->run();
113
114
        $client = $this->getClient();
115
116
        return $this->render('finish', [
117
            'balance' => $client->balance,
118
            'currency' => $client->currency,
119
            'success' => $finisher->getSuccess(),
120
            'error' => $finisher->getError(),
121
            'pending' => $finisher->getPending(),
122
            'remarks' => (array) Yii::$app->getView()->params['remarks'],
123
        ]);
124
    }
125
126
    private function getClient(): Client
127
    {
128
         return Client::find()
129
            ->withPurses()
130
            ->where(['id' => Yii::$app->user->identity->id])
131
            ->one();
132
    }
133
}
134