CartController   A
last analyzed

Complexity

Total Complexity 10

Size/Duplication

Total Lines 113
Duplicated Lines 12.39 %

Coupling/Cohesion

Components 1
Dependencies 10

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 10
lcom 1
cbo 10
dl 14
loc 113
ccs 0
cts 49
cp 0
rs 10
c 0
b 0
f 0

8 Methods

Rating   Name   Duplication   Size   Complexity  
A behaviors() 0 15 1
A renderDeposit() 0 15 2
A actionSelect() 0 6 1
A getNegotiator() 0 12 2
A actionFull() 7 7 1
A actionPartial() 7 7 1
A actionFinish() 0 22 1
A getClient() 0 7 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Finance module for HiPanel
4
 *
5
 * @link      https://github.com/hiqdev/hipanel-module-finance
6
 * @package   hipanel-module-finance
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hipanel\modules\finance\controllers;
12
13
use hipanel\filters\EasyAccessControl;
14
use hipanel\helpers\Url;
15
use hipanel\modules\client\models\Client;
16
use hipanel\modules\finance\cart\CartFinisher;
17
use hipanel\modules\finance\widgets\CartCurrencyNegotiator;
18
use hipanel\modules\finance\Module;
19
use hiqdev\yii2\merchant\models\DepositForm;
20
use Yii;
21
22
class CartController extends \yii\web\Controller
23
{
24
    /**
25
     * @var Module
26
     */
27
    public $module;
28
29
    public function behaviors()
30
    {
31
        return [
32
            [
33
                'class' => EasyAccessControl::class,
34
                'actions' => [
35
                    'deposit' => '@',
36
                    'select' => '@',
37
                    'partial' => '@',
38
                    'full' => '@',
39
                    'finish' => '@',
40
                ],
41
            ],
42
        ];
43
    }
44
45
    /**
46
     * @param float $amount
47
     * @param string $currency
48
     * @return \yii\web\Response
49
     */
50
    private function renderDeposit(float $amount, string $currency)
51
    {
52
        $cart = $this->module->getCart();
53
54
        $form = new DepositForm([
55
            'amount' => $amount,
56
            'currency' => $currency,
57
            'finishUrl' => $cart->getCurrency() === $currency
58
                ? Url::to(['@finance/cart/finish'])
59
                : Url::to(['@finance/cart/finish', 'exchangeFromCurrency' => $currency])
60
        ]);
61
        $form->validate();
62
63
        return $this->module->getMerchant()->renderDeposit($form);
64
    }
65
66
    public function actionSelect()
67
    {
68
        return $this->render('select', [
69
            'negotiator' => $this->getNegotiator()
70
        ]);
71
    }
72
73
    /** @var \hipanel\modules\finance\widgets\CartCurrencyNegotiator */
74
    private $negotiator;
75
    private function getNegotiator(): CartCurrencyNegotiator
76
    {
77
        if ($this->negotiator === null) {
78
            $this->negotiator = new CartCurrencyNegotiator([
79
                'cart' => $this->module->getCart(),
80
                'client' => $this->getClient(),
81
                'merchantModule' => $this->module->getMerchant(),
82
            ]);
83
        }
84
85
        return $this->negotiator;
86
    }
87
88 View Code Duplication
    public function actionFull(string $currency = null)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
89
    {
90
        $negotiator = $this->getNegotiator();
91
        $currency = $currency ?? $this->module->getCart()->getCurrency();
92
93
        return $this->renderDeposit($negotiator->getFullAmount($currency), $currency);
94
    }
95
96 View Code Duplication
    public function actionPartial(string $currency = null)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
97
    {
98
        $negotiator = $this->getNegotiator();
99
        $currency = $currency ?? $this->module->getCart()->getCurrency();
100
101
        return $this->renderDeposit($negotiator->getPartialAmount($currency), $currency);
102
    }
103
104
    public function actionFinish(string $exchangeFromCurrency = null)
105
    {
106
        $cart = $this->module->getCart();
107
108
        $finisher = new CartFinisher([
109
            'cart' => $cart,
110
            'exchangeFromCurrency' => $exchangeFromCurrency,
111
            'user' => Yii::$app->user,
112
        ]);
113
        $finisher->run();
114
115
        $client = $this->getClient();
116
117
        return $this->render('finish', [
118
            'balance' => $client->balance,
119
            'currency' => $client->currency,
120
            'success' => $finisher->getSuccess(),
121
            'error' => $finisher->getError(),
122
            'pending' => $finisher->getPending(),
123
            'remarks' => (array) Yii::$app->getView()->params['remarks'],
124
        ]);
125
    }
126
127
    private function getClient(): Client
128
    {
129
         return Client::find()
130
            ->withPurses()
131
            ->where(['id' => Yii::$app->user->identity->id])
132
            ->one();
133
    }
134
}
135