Price::formulaLines() - Code Metrics - Inspection of "Working on prices: formula input & help, estimates" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4f1415...383c20 )

by Dmitry

created 2018-06-06 09:47 UTC

Price::formulaLines() A

↳ Parent: Price

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	8
c	0
b	0
f	0
ccs	0
cts	5
cp	0
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php

namespace hipanel\modules\finance\models;

use Yii;
use yii\helpers\Inflector;
use yii\helpers\StringHelper;
use hipanel\models\Ref;
use hipanel\modules\finance\models\factories\PriceModelFactory;

/**
 * Class Price
 *
 * @property int $id
 * @property int $plan_id
 * @property string|int $object_id
 * @property string|float $price
 * @property string $currency
 * @property string|int $main_object_id
 * @property string $unit
 * @property string $type
 * @property string $quantity
 * @property string $formula
 *
 * @property TargetObject $object
 * @property Plan $plan
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class Price extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    const SCENARIO_CREATE = 'create';
    const SCENARIO_UPDATE = 'update';
    const SCENARIO_DELETE = 'delete';

    public function rules()
    {
        return array_merge(parent::rules(), [
            [['id', 'parent_id', 'plan_id', 'object_id', 'type_id', 'unit_id', 'currency_id', 'main_object_id'], 'integer'],
            [['type', 'plan_name', 'unit', 'currency', 'note', 'data'], 'string'],
            [['quantity', 'price'], 'number'],
            [['class'], 'string'], // todo: probably, refactor is needed

            [['plan_id', 'type', 'price', 'currency'], 'required', 'on' => ['create', 'update']],
            [['id'], 'required', 'on' => ['update', 'set-note', 'delete']],
            [['class'], 'default', 'value' => function ($model) {

                return (new \ReflectionClass($this))->getShortName();
            }],
            [['class'], 'string'],
            [['formula'], 'string', 'on' => ['create', 'update']] // TODO syn check
        ]);
    }

    public function attributeLabels()
    {
        return [
            'plan_id' => Yii::t('hipanel:finance', 'Tariff plan'),
            'plan' => Yii::t('hipanel:finance', 'Tariff plan'),
            'quantity' => Yii::t('hipanel:finance', 'Prepaid'),
            'unit' => Yii::t('hipanel:finance', 'Unit'),
            'price' => Yii::t('hipanel:finance', 'Price'),
            'formula' => Yii::t('hipanel.finance.price', 'Formula'),
            'note' => Yii::t('hipanel', 'Note'),
            'type' => Yii::t('hipanel', 'Type'),
        ];
    }

    public function getTypeOptions()
    {
        return Ref::getList('type,bill', null, [
            'select' => 'oname_label',
            'pnames' => 'monthly,overuse',
            'with_recursive' => 1,
            'mapOptions' => ['from' => 'oname'],
        ]);
    }

    public function getUnitOptions()
    {
        $unitGroup = [
            'speed' => ['bps', 'kbps', 'mbps', 'gbps', 'tbps'],
            'size' => ['mb', 'mb10', 'mb100', 'gb', 'tb'],
        ];

        $availableUnitsByPriceType = [
            'overuse,ip_num' => ['items'],
            'overuse,support_time' => ['hour'],
            'overuse,backup_du' => $unitGroup['size'],
            'overuse,server_traf_max' => $unitGroup['size'],
            'overuse,server_traf95_max' => $unitGroup['speed'],
            'overuse,server_du' => $unitGroup['size'],
            'overuse,server_ssd' => $unitGroup['size'],
            'overuse,server_sata' => $unitGroup['size'],
        ];

        $units = Ref::getList('type,unit', 'hipanel.finance.units', [
            'with_recursive' => 1,
            'select' => 'oname_label',
            'mapOptions' => ['from' => 'oname'],
        ]);

        $possibleTypes = $availableUnitsByPriceType[$this->type] ?? [];
        return array_intersect_key($units, array_combine($possibleTypes, $possibleTypes));
    }

    public function getUnitLabel()
    {
        return $this->getUnitOptions()[$this->unit] ?? null;
    }

    public function getCurrencyOptions()
    {
        return Ref::getList('type,currency');
    }

    public function getObject()
    {
        return $this->hasOne(TargetObject::class, ['id' => 'id']);
    }

    public function getPlan()
    {
        return $this->hasOne(Plan::class, ['id' => 'plan_id']);
    }

    public static function tableName()
    {
        return Inflector::camel2id(StringHelper::basename(__CLASS__), '-');
    }

    public function isOveruse()
    {
        return strpos($this->type, 'overuse,') === 0;
    }

    public function getSubtype()
    {
        [, $subtype] = explode(',', $this->type);

        return $subtype;
    }

    /**
     * {@inheritdoc}
     */
    public static function instantiate($row)
    {
        if (empty($row['class'])) {
            return parent::instance($row);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        /** @var PriceModelFactory $factory */
        $factory = Yii::$container->get(PriceModelFactory::class);
        return $factory->build($row['class']);
    }

    public function formulaLines(): array
    {
        if (strlen($this->formula) === 0) {
            return [];
        }

        return explode("\n", $this->formula);
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\models;
4
5			use Yii;
6			use yii\helpers\Inflector;
7			use yii\helpers\StringHelper;
8			use hipanel\models\Ref;
9			use hipanel\modules\finance\models\factories\PriceModelFactory;
10
11			/**
12			* Class Price
13			*
14			* @property int $id
15			* @property int $plan_id
16			* @property string\|int $object_id
17			* @property string\|float $price
18			* @property string $currency
19			* @property string\|int $main_object_id
20			* @property string $unit
21			* @property string $type
22			* @property string $quantity
23			* @property string $formula
24			*
25			* @property TargetObject $object
26			* @property Plan $plan
27			*
28			* @author Dmytro Naumenko <[email protected]>
29			*/
30			class Price extends \hipanel\base\Model
31			{
32			use \hipanel\base\ModelTrait;
33
34			const SCENARIO_CREATE = 'create';
35			const SCENARIO_UPDATE = 'update';
36			const SCENARIO_DELETE = 'delete';
37
38			public function rules()
39			{
40			return array_merge(parent::rules(), [
41			[['id', 'parent_id', 'plan_id', 'object_id', 'type_id', 'unit_id', 'currency_id', 'main_object_id'], 'integer'],
42			[['type', 'plan_name', 'unit', 'currency', 'note', 'data'], 'string'],
43			[['quantity', 'price'], 'number'],
44			[['class'], 'string'], // todo: probably, refactor is needed
45
46			[['plan_id', 'type', 'price', 'currency'], 'required', 'on' => ['create', 'update']],
47			[['id'], 'required', 'on' => ['update', 'set-note', 'delete']],
48			[['class'], 'default', 'value' => function ($model) {
			0 ignored issues – show Unused Code introduced 2018-02-09 10:26 UTC by Report Bug Copy Issue Report The parameter `$model` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
49			return (new \ReflectionClass($this))->getShortName();
50			}],
51			[['class'], 'string'],
52			[['formula'], 'string', 'on' => ['create', 'update']] // TODO syn check
53			]);
54			}
55
56			public function attributeLabels()
57			{
58			return [
59			'plan_id' => Yii::t('hipanel:finance', 'Tariff plan'),
60			'plan' => Yii::t('hipanel:finance', 'Tariff plan'),
61			'quantity' => Yii::t('hipanel:finance', 'Prepaid'),
62			'unit' => Yii::t('hipanel:finance', 'Unit'),
63			'price' => Yii::t('hipanel:finance', 'Price'),
64			'formula' => Yii::t('hipanel.finance.price', 'Formula'),
65			'note' => Yii::t('hipanel', 'Note'),
66			'type' => Yii::t('hipanel', 'Type'),
67			];
68			}
69
70			public function getTypeOptions()
71			{
72			return Ref::getList('type,bill', null, [
73			'select' => 'oname_label',
74			'pnames' => 'monthly,overuse',
75			'with_recursive' => 1,
76			'mapOptions' => ['from' => 'oname'],
77			]);
78			}
79
80			public function getUnitOptions()
81			{
82			$unitGroup = [
83			'speed' => ['bps', 'kbps', 'mbps', 'gbps', 'tbps'],
84			'size' => ['mb', 'mb10', 'mb100', 'gb', 'tb'],
85			];
86
87			$availableUnitsByPriceType = [
88			'overuse,ip_num' => ['items'],
89			'overuse,support_time' => ['hour'],
90			'overuse,backup_du' => $unitGroup['size'],
91			'overuse,server_traf_max' => $unitGroup['size'],
92			'overuse,server_traf95_max' => $unitGroup['speed'],
93			'overuse,server_du' => $unitGroup['size'],
94			'overuse,server_ssd' => $unitGroup['size'],
95			'overuse,server_sata' => $unitGroup['size'],
96			];
97
98			$units = Ref::getList('type,unit', 'hipanel.finance.units', [
99			'with_recursive' => 1,
100			'select' => 'oname_label',
101			'mapOptions' => ['from' => 'oname'],
102			]);
103
104			$possibleTypes = $availableUnitsByPriceType[$this->type] ?? [];
105			return array_intersect_key($units, array_combine($possibleTypes, $possibleTypes));
106			}
107
108			public function getUnitLabel()
109			{
110			return $this->getUnitOptions()[$this->unit] ?? null;
111			}
112
113			public function getCurrencyOptions()
114			{
115			return Ref::getList('type,currency');
116			}
117
118			public function getObject()
119			{
120			return $this->hasOne(TargetObject::class, ['id' => 'id']);
121			}
122
123			public function getPlan()
124			{
125			return $this->hasOne(Plan::class, ['id' => 'plan_id']);
126			}
127
128			public static function tableName()
129			{
130			return Inflector::camel2id(StringHelper::basename(__CLASS__), '-');
131			}
132
133			public function isOveruse()
134			{
135			return strpos($this->type, 'overuse,') === 0;
136			}
137
138			public function getSubtype()
139			{
140			[, $subtype] = explode(',', $this->type);
			0 ignored issues – show Bug introduced 2018-05-25 16:41 UTC by Report Bug Copy Issue Report The variable `$subtype` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
141			return $subtype;
142			}
143
144			/**
145			* {@inheritdoc}
146			*/
147			public static function instantiate($row)
148			{
149			if (empty($row['class'])) {
150			return parent::instance($row);
			0 ignored issues – show Comprehensibility Bug introduced 2018-02-09 10:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`instance()` instead of `instantiate()`). Are you sure this is correct? If so, you might want to change this to `$this->instance()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
151			}
152
153			/** @var PriceModelFactory $factory */
154			$factory = Yii::$container->get(PriceModelFactory::class);
155			return $factory->build($row['class']);
156			}
157
158			public function formulaLines(): array
159			{
160			if (strlen($this->formula) === 0) {
161			return [];
162			}
163
164			return explode("\n", $this->formula);
165			}
166			}
167

hiqdev / hipanel-module-finance

Push — master ( 4f1415...383c20 )

Price::formulaLines() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like